weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Update nameserver lookup test to use upstream targets

Browse Source 
In the long term I don't think this test should be run as a unit test
because it can randomly break due to changes in DNS config we don't
control, which is a pretty poor user experience for someone trying to
change unrelated code.

If we're going to run this kind of check, we should probably run it as a
periodic rather than a presubmit, perhaps with the test being run on
presubmit when the DNS util code is changed.

But that's all more work than I can really do now. Instead, I'll copy
what the upstream go-lego is doing, which should unblock us for now:

07c4daeff3/challenge/dns01/nameserver_test.go

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
This commit is contained in:
Ashley Davis 2023-08-09 09:27:30 +01:00
parent f8851e4641
commit a53bec25e7
No known key found for this signature in database
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/issuer/acme/dns/util/wait_test.go
View File

@ -22,11 +22,17 @@ var lookupNameserversTestsOK = []struct {
fqdn string fqdn string
nss []string nss []string
}{ }{
{"books.google.com.ng.", {
[]string{"ns1.google.com.", "ns2.google.com.", "ns3.google.com.", "ns4.google.com."}, fqdn: "en.wikipedia.org.",
nss: []string{"ns0.wikimedia.org.", "ns1.wikimedia.org.", "ns2.wikimedia.org."},
}, },
{"www.google.com.", {
[]string{"ns1.google.com.", "ns2.google.com.", "ns3.google.com.", "ns4.google.com."}, fqdn: "www.google.com.",
nss: []string{"ns1.google.com.", "ns2.google.com.", "ns3.google.com.", "ns4.google.com."},
},
{
fqdn: "physics.georgetown.edu.",
nss: []string{"ns4.georgetown.edu.", "ns5.georgetown.edu.", "ns6.georgetown.edu."},
}, },
} }