weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #967 from munnerz/unused-args

Browse Source 
Remove unused arg from GenerateTemplate
This commit is contained in:
jetstack-bot 2018-10-16 14:36:36 +01:00 committed by GitHub
commit 9eab875005
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/issuer/ca/issue.go
View File

@ -114,7 +114,7 @@ func (c *CA) obtainCertificate(crt *v1alpha1.Certificate, signeeKey interface{},
return nil, fmt.Errorf("error getting issuer private key: %s", err.Error())
}
template, err := pki.GenerateTemplate(c.issuer, crt, nil)
template, err := pki.GenerateTemplate(c.issuer, crt)
if err != nil {
return nil, err
}

2
pkg/issuer/selfsigned/issue.go
View File

@ -91,7 +91,7 @@ func (c *SelfSigned) obtainCertificate(crt *v1alpha1.Certificate, privateKey cry
return nil, err
}
template, err := pki.GenerateTemplate(c.issuer, crt, nil)
template, err := pki.GenerateTemplate(c.issuer, crt)
if err != nil {
return nil, err
}

2
pkg/util/pki/csr.go
View File

@ -124,7 +124,7 @@ func GenerateCSR(issuer v1alpha1.GenericIssuer, crt *v1alpha1.Certificate) (*x50
// This should create a Certificate template that is equivalent to the CertificateRequest
// generated by GenerateCSR.
// The PublicKey field must be populated by the caller.
func GenerateTemplate(issuer v1alpha1.GenericIssuer, crt *v1alpha1.Certificate, serialNo *big.Int) (*x509.Certificate, error) {
func GenerateTemplate(issuer v1alpha1.GenericIssuer, crt *v1alpha1.Certificate) (*x509.Certificate, error) {
commonName := CommonNameForCertificate(crt)
dnsNames := DNSNamesForCertificate(crt)
organization := OrganizationForCertificate(crt)