weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #1121 from munnerz/crt-issue-status-condition

Browse Source 
Don't update Certificate status condition upon issuance
This commit is contained in:
jetstack-bot 2018-11-30 11:42:13 +00:00 committed by GitHub
commit 9d6a0e1fb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/controller/certificates/sync.go
View File

@ -55,12 +55,6 @@ const (
successCertificateRenewed = "CertRenewed"
messageErrorSavingCertificate = "Error saving TLS certificate: "
messageIssuingCertificate = "Issuing certificate..."
messageRenewingCertificate = "Renewing certificate..."
messageCertificateIssued = "Certificate issued successfully"
messageCertificateRenewed = "Certificate renewed successfully"
)
const (
@ -365,11 +359,7 @@ func (c *Controller) issue(ctx context.Context, issuer issuer.Interface, crt *v1
}
if len(resp.Certificate) > 0 {
s := messageCertificateIssued
glog.Info(s)
c.Recorder.Event(crt, corev1.EventTypeNormal, successCertificateIssued, s)
crt.UpdateStatusCondition(v1alpha1.CertificateConditionReady, v1alpha1.ConditionTrue, successCertificateIssued, s, true)
c.Recorder.Event(crt, corev1.EventTypeNormal, successCertificateIssued, "Certificate issued successfully")
// as we have just written a certificate, we should schedule it for renewal
c.scheduleRenewal(crt)
}