weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

issuer/route53: remove unused integ test

Browse Source 
I'm convinced this test was never run and also did not provide any
significant value in this project.
This commit is contained in:
Euan Kemp 2018-03-15 19:49:24 -07:00 committed by Euan Kemp
parent 0d39da5174
commit 971ef4f198
2 changed files with 3 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
pkg/issuer/acme/dns/route53/route53_integration_test.go
View File

@ -1,70 +0,0 @@
package route53
import (
"fmt"
"os"
"testing"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/session"
"github.com/aws/aws-sdk-go/service/route53"
)
func TestRoute53TTL(t *testing.T) {
m, err := testGetAndPreCheck()
if err != nil {
t.Skip(err.Error())
}
provider, err := NewDNSProviderAccessKey("", "", "", "")
if err != nil {
t.Fatalf("Fatal: %s", err.Error())
}
err = provider.Present(m["route53Domain"], "foo", "bar")
if err != nil {
t.Fatalf("Fatal: %s", err.Error())
}
// we need a separate R53 client here as the one in the DNS provider is
// unexported.
fqdn := "_acme-challenge." + m["route53Domain"] + "."
svc := route53.New(session.New())
zoneID, err := provider.getHostedZoneID(fqdn)
if err != nil {
provider.CleanUp(m["route53Domain"], "foo", "bar")
t.Fatalf("Fatal: %s", err.Error())
}
params := &route53.ListResourceRecordSetsInput{
HostedZoneId: aws.String(zoneID),
}
resp, err := svc.ListResourceRecordSets(params)
if err != nil {
provider.CleanUp(m["route53Domain"], "foo", "bar")
t.Fatalf("Fatal: %s", err.Error())
}
for _, v := range resp.ResourceRecordSets {
if *v.Name == fqdn && *v.Type == "TXT" && *v.TTL == 10 {
provider.CleanUp(m["route53Domain"], "foo", "bar")
return
}
}
provider.CleanUp(m["route53Domain"], "foo", "bar")
t.Fatalf("Could not find a TXT record for _acme-challenge.%s with a TTL of 10", m["route53Domain"])
}
func testGetAndPreCheck() (map[string]string, error) {
m := map[string]string{
"route53Key": os.Getenv("AWS_ACCESS_KEY_ID"),
"route53Secret": os.Getenv("AWS_SECRET_ACCESS_KEY"),
"route53Region": os.Getenv("AWS_REGION"),
"route53Domain": os.Getenv("R53_DOMAIN"),
}
for _, v := range m {
if v == "" {
return nil, fmt.Errorf("AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_REGION, and R53_DOMAIN are needed to run this test")
}
}
return m, nil
}

6
pkg/issuer/acme/dns/route53/route53_test.go
View File

@ -49,7 +49,7 @@ func TestAmbientCredentialsFromEnv(t *testing.T) {
os.Setenv("AWS_REGION", "us-east-1")
defer restoreRoute53Env()
provider, err := NewDNSProviderAmbient("", "", "", "")
provider, err := NewDNSProvider("", "", "", "", true)
assert.NoError(t, err, "Expected no error constructing DNSProvider")
_, err = provider.client.Config.Credentials.Get()
@ -62,7 +62,7 @@ func TestNoCredentialsFromEnv(t *testing.T) {
os.Setenv("AWS_REGION", "us-east-1")
defer restoreRoute53Env()
_, err := NewDNSProviderAccessKey("", "", "", "")
_, err := NewDNSProvider("", "", "", "", false)
assert.Error(t, err, "Expected error constructing DNSProvider with no credentials and not ambient")
}
@ -70,7 +70,7 @@ func TestAmbientRegionFromEnv(t *testing.T) {
os.Setenv("AWS_REGION", "us-east-1")
defer restoreRoute53Env()
provider, err := NewDNSProviderAmbient("", "", "", "")
provider, err := NewDNSProvider("", "", "", "", true)
assert.NoError(t, err, "Expected no error constructing DNSProvider")
assert.Equal(t, "us-east-1", *provider.client.Config.Region, "Expected Region to be set from environment")