From 965757cce0bed7e70ec37c43d2c55be30b2e8def Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Mon, 15 Oct 2018 22:46:26 +0100 Subject: [PATCH] Retry order if existing Order certificate is invalid Signed-off-by: James Munnelly --- pkg/issuer/acme/issue.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/issuer/acme/issue.go b/pkg/issuer/acme/issue.go index b4ac5089d..41f07994b 100644 --- a/pkg/issuer/acme/issue.go +++ b/pkg/issuer/acme/issue.go @@ -177,8 +177,8 @@ func (a *Acme) Issue(ctx context.Context, crt *v1alpha1.Certificate) (issuer.Iss x509Cert, err := x509.ParseCertificate(certSlice[0]) if err != nil { - // TODO: parse returned ACME error and potentially re-create order. - return issuer.IssueResponse{}, fmt.Errorf("failed to parse returned x509 certificate: %v", err.Error()) + // if parsing the certificate fails, recreate the order + return a.retryOrder(crt, existingOrder) } if a.Context.IssuerOptions.CertificateNeedsRenew(x509Cert) {