From 8e70778f4f2eb0391e1fc33afb361b9ac01d1b52 Mon Sep 17 00:00:00 2001
From: Ashley Davis <ashley.davis@venafi.com>
Date: Thu, 18 Apr 2024 12:43:08 +0100
Subject: [PATCH] use existing object in more tests

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
---
 .../validation/certificate_test.go            | 32 +++++--------------
 1 file changed, 8 insertions(+), 24 deletions(-)

diff --git a/internal/apis/certmanager/validation/certificate_test.go b/internal/apis/certmanager/validation/certificate_test.go
index e5ffec6c7..09d8f7ab7 100644
--- a/internal/apis/certmanager/validation/certificate_test.go
+++ b/internal/apis/certmanager/validation/certificate_test.go
@@ -615,9 +615,7 @@ func TestValidateCertificate(t *testing.T) {
 						Annotations: map[string]string{},
 						Labels:      map[string]string{},
 					},
-					IssuerRef: cmmeta.ObjectReference{
-						Name: "valid",
-					},
+					IssuerRef: validIssuerRef,
 				},
 			},
 			a: someAdmissionRequest,
@@ -635,9 +633,7 @@ func TestValidateCertificate(t *testing.T) {
 							"my-label.com/foo": "evn-production",
 						},
 					},
-					IssuerRef: cmmeta.ObjectReference{
-						Name: "valid",
-					},
+					IssuerRef: validIssuerRef,
 				},
 			},
 			a: someAdmissionRequest,
@@ -655,9 +651,7 @@ func TestValidateCertificate(t *testing.T) {
 							"cert-manager.io/allow-direct-injection": "true",
 						},
 					},
-					IssuerRef: cmmeta.ObjectReference{
-						Name: "invalid",
-					},
+					IssuerRef: validIssuerRef,
 				},
 			},
 			a: someAdmissionRequest,
@@ -676,9 +670,7 @@ func TestValidateCertificate(t *testing.T) {
 							"app.com/invalid": strings.Repeat("0", maxSecretTemplateAnnotationsBytesLimit),
 						},
 					},
-					IssuerRef: cmmeta.ObjectReference{
-						Name: "invalid",
-					},
+					IssuerRef: validIssuerRef,
 				},
 			},
 			a: someAdmissionRequest,
@@ -696,9 +688,7 @@ func TestValidateCertificate(t *testing.T) {
 							"app.com/invalid-chars": "invalid=chars",
 						},
 					},
-					IssuerRef: cmmeta.ObjectReference{
-						Name: "invalid",
-					},
+					IssuerRef: validIssuerRef,
 				},
 			},
 			a: someAdmissionRequest,
@@ -720,9 +710,7 @@ func TestValidateCertificate(t *testing.T) {
 							DNSDomains: []string{"example.com"},
 						},
 					},
-					IssuerRef: cmmeta.ObjectReference{
-						Name: "valid",
-					},
+					IssuerRef: validIssuerRef,
 				},
 			},
 			a:                             someAdmissionRequest,
@@ -735,9 +723,7 @@ func TestValidateCertificate(t *testing.T) {
 					SecretName:      "abc",
 					IsCA:            true,
 					NameConstraints: &internalcmapi.NameConstraints{},
-					IssuerRef: cmmeta.ObjectReference{
-						Name: "valid",
-					},
+					IssuerRef:       validIssuerRef,
 				},
 			},
 			a: someAdmissionRequest,
@@ -758,9 +744,7 @@ func TestValidateCertificate(t *testing.T) {
 							DNSDomains: []string{"example.com"},
 						},
 					},
-					IssuerRef: cmmeta.ObjectReference{
-						Name: "valid",
-					},
+					IssuerRef: validIssuerRef,
 				},
 			},
 			a: someAdmissionRequest,