From 307e7b6087a3f1960ac4e735dddff6383fa2e74f Mon Sep 17 00:00:00 2001 From: Richard Wall Date: Fri, 26 Jan 2024 17:44:07 +0000 Subject: [PATCH 1/2] Unhide the SingleInflight warning Signed-off-by: Richard Wall --- .golangci.ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.ci.yaml b/.golangci.ci.yaml index e0564514d..8afea8633 100644 --- a/.golangci.ci.yaml +++ b/.golangci.ci.yaml @@ -34,4 +34,4 @@ issues: text: "SA(1002|1006|4000|4006)" - linters: - staticcheck - text: "(NewCertManagerBasicCertificate|DeprecatedCertificateTemplateFromCertificateRequestAndAllowInsecureCSRUsageDefinition|testCA.Subjects|RootCAs.Subjects|pki.GenerateTemplate|c.SingleInflight)" + text: "(NewCertManagerBasicCertificate|DeprecatedCertificateTemplateFromCertificateRequestAndAllowInsecureCSRUsageDefinition|testCA.Subjects|RootCAs.Subjects|pki.GenerateTemplate)" From ee5cba487ab7642716422ad1e703a1ac1f2d288a Mon Sep 17 00:00:00 2001 From: Richard Wall Date: Fri, 26 Jan 2024 17:53:50 +0000 Subject: [PATCH 2/2] Stop using the deprecated SingleInflight field of miekg/dns Signed-off-by: Richard Wall --- pkg/issuer/acme/dns/rfc2136/rfc2136.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/issuer/acme/dns/rfc2136/rfc2136.go b/pkg/issuer/acme/dns/rfc2136/rfc2136.go index 4c192e56b..8c6f5cfb9 100644 --- a/pkg/issuer/acme/dns/rfc2136/rfc2136.go +++ b/pkg/issuer/acme/dns/rfc2136/rfc2136.go @@ -127,7 +127,6 @@ func (r *DNSProvider) changeRecord(action, fqdn, zone, value string, ttl int) er // Setup client c := new(dns.Client) c.TsigProvider = tsigHMACProvider(r.tsigSecret) - c.SingleInflight = true // TSIG authentication / msg signing if len(r.tsigKeyName) > 0 && len(r.tsigSecret) > 0 { m.SetTsig(dns.Fqdn(r.tsigKeyName), r.tsigAlgorithm, 300, time.Now().Unix())