weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix feedback

Browse Source 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
This commit is contained in:
Tim Ramlot 2023-05-05 14:51:55 +02:00
parent c113a3eadc
commit 8747adf629
No known key found for this signature in database
GPG Key ID: 47428728E0C2878D
3 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/acmesolver/app/app.go
View File

@ -74,7 +74,7 @@ func NewACMESolverCommand(stopCh <-chan struct{}) *cobra.Command {
cmd.Flags().StringVar(&s.Token, "token", "", "the challenge token to verify against")
cmd.Flags().StringVar(&s.Key, "key", "", "the challenge key to respond with")
// TODO(@inteon): use flags to configure the log configuration
// TODO(@inteon): use flags to configure the log configuration (https://github.com/cert-manager/cert-manager/issues/6021)
return cmd
}

15
cmd/cainjector/app/start.go
View File

@ -134,14 +134,13 @@ func (o *InjectorControllerOptions) AddFlags(fs *pflag.FlagSet) {
logf.AddFlags(o.Logging, fs)
{
var controllerRuntimeFlags flag.FlagSet
config.RegisterFlags(&controllerRuntimeFlags)
controllerRuntimeFlags.VisitAll(func(f *flag.Flag) {
fs.AddGoFlag(f)
})
}
// The controller-runtime flag (--kubeconfig) that we need
// relies on the "flag" package but we use "spf13/pflag".
var controllerRuntimeFlags flag.FlagSet
config.RegisterFlags(&controllerRuntimeFlags)
controllerRuntimeFlags.VisitAll(func(f *flag.Flag) {
fs.AddGoFlag(f)
})
}
// NewInjectorControllerOptions returns a new InjectorControllerOptions

1
pkg/logs/logs.go
View File

@ -69,7 +69,6 @@ func InitLogs() {
}
func AddFlags(opts *logs.Options, fs *pflag.FlagSet) {
// init deprecated flags
{
var allFlags flag.FlagSet
klog.InitFlags(&allFlags)