weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

removed unused NewCertManagerWebhookServer function argument

Browse Source 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
This commit is contained in:
Tim Ramlot 2023-02-28 12:30:44 +01:00
parent 9a4cad7472
commit 82beacaee2
No known key found for this signature in database
GPG Key ID: 47428728E0C2878D
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/webhook/app/testing/testwebhook.go
View File

@ -99,7 +99,7 @@ func StartWebhookServer(t *testing.T, ctx context.Context, args []string, argume
webhookConfig.HealthzPort = pointer.Int(0)
errCh := make(chan error)
srv, err := webhook.NewCertManagerWebhookServer(log, *webhookFlags, *webhookConfig, argumentsForNewServerWithOptions...)
srv, err := webhook.NewCertManagerWebhookServer(log, *webhookConfig, argumentsForNewServerWithOptions...)
if err != nil {
t.Fatal(err)
}

2
cmd/webhook/app/webhook.go
View File

@ -117,7 +117,7 @@ func NewServerCommand(stopCh <-chan struct{}) *cobra.Command {
}
}
srv, err := cmwebhook.NewCertManagerWebhookServer(log, *webhookFlags, *webhookConfig)
srv, err := cmwebhook.NewCertManagerWebhookServer(log, *webhookConfig)
if err != nil {
log.Error(err, "Failed initialising server")
os.Exit(1)

3
internal/webhook/webhook.go
View File

@ -27,7 +27,6 @@ import (
"k8s.io/client-go/rest"
"k8s.io/client-go/tools/clientcmd"
"github.com/cert-manager/cert-manager/cmd/webhook/app/options"
acmeinstall "github.com/cert-manager/cert-manager/internal/apis/acme/install"
cminstall "github.com/cert-manager/cert-manager/internal/apis/certmanager/install"
config "github.com/cert-manager/cert-manager/internal/apis/config/webhook"
@ -54,7 +53,7 @@ func WithConversionHandler(handler handlers.ConversionHook) func(*server.Server)
// NewCertManagerWebhookServer creates a new webhook server configured with all cert-manager
// resource types, validation, defaulting and conversion functions.
func NewCertManagerWebhookServer(log logr.Logger, _ options.WebhookFlags, opts config.WebhookConfiguration, optionFunctions ...func(*server.Server)) (*server.Server, error) {
func NewCertManagerWebhookServer(log logr.Logger, opts config.WebhookConfiguration, optionFunctions ...func(*server.Server)) (*server.Server, error) {
restcfg, err := clientcmd.BuildConfigFromFlags(opts.APIServerHost, opts.KubeConfig)
if err != nil {
return nil, err