From 7a7d853d9fa75b8b8ec6ca343db396f7e2339070 Mon Sep 17 00:00:00 2001 From: irbekrm Date: Mon, 23 Aug 2021 08:05:29 +0100 Subject: [PATCH] Add a comment about staticcheck script Also shift the correct number of params and remove and unused def. Signed-off-by: irbekrm --- hack/bin/deps.bzl | 1 - hack/update-deps-licenses.sh | 2 +- hack/update-deps.sh | 2 +- hack/verify-staticcheck.sh | 4 ++++ 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hack/bin/deps.bzl b/hack/bin/deps.bzl index 22afe172c..dc2f3f416 100644 --- a/hack/bin/deps.bzl +++ b/hack/bin/deps.bzl @@ -16,7 +16,6 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_file", "http_archive" load("@bazel_gazelle//:deps.bzl", "go_repository") def install(): - install_misc() install_integration_test_dependencies() install_staticcheck() install_helm() diff --git a/hack/update-deps-licenses.sh b/hack/update-deps-licenses.sh index e089e5cb8..726185083 100755 --- a/hack/update-deps-licenses.sh +++ b/hack/update-deps-licenses.sh @@ -52,7 +52,7 @@ fi go=$(realpath "$1") export PATH=$(dirname "$go"):$PATH -shift 2 +shift 1 REPO_ROOT="$BUILD_WORKSPACE_DIRECTORY" LICENSE_ROOT="$REPO_ROOT" diff --git a/hack/update-deps.sh b/hack/update-deps.sh index e8e2a3d7c..cccc2c210 100755 --- a/hack/update-deps.sh +++ b/hack/update-deps.sh @@ -50,7 +50,7 @@ update_deps_licenses=( "$go" ) -shift 6 +shift 5 cd "$BUILD_WORKSPACE_DIRECTORY" trap 'echo "FAILED" >&2' ERR diff --git a/hack/verify-staticcheck.sh b/hack/verify-staticcheck.sh index fb96de4ec..9721b6047 100755 --- a/hack/verify-staticcheck.sh +++ b/hack/verify-staticcheck.sh @@ -18,6 +18,10 @@ set -o errexit set -o nounset set -o pipefail +# This script is currently not run as part of any automated tests. +# https://github.com/jetstack/cert-manager/pull/3037#issue-440523030 +# It will also currently only work on linux/amd64, darwin/amd64. + REPO_ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )/../" > /dev/null && pwd )" # See https://staticcheck.io/docs/checks