diff --git a/pkg/controller/certificaterequests/venafi/venafi_test.go b/pkg/controller/certificaterequests/venafi/venafi_test.go index d96464ad2..4e2048891 100644 --- a/pkg/controller/certificaterequests/venafi/venafi_test.go +++ b/pkg/controller/certificaterequests/venafi/venafi_test.go @@ -831,7 +831,7 @@ func runTest(t *testing.T, test testT) { if test.fakeClient != nil { v.clientBuilder = func(namespace string, secretsLister corelisters.SecretLister, - issuer cmapi.GenericIssuer, metrics *metrics.Metrics, _ logr.Logger) (client.Interface, error) { + issuer cmapi.GenericIssuer, _ *metrics.Metrics, _ logr.Logger) (client.Interface, error) { return test.fakeClient, nil } } diff --git a/pkg/metrics/acme.go b/pkg/metrics/acme.go index 8926ed819..0bb130d3d 100644 --- a/pkg/metrics/acme.go +++ b/pkg/metrics/acme.go @@ -14,14 +14,6 @@ See the License for the specific language governing permissions and limitations under the License. */ -// Package metrics contains global structures related to metrics collection -// cert-manager exposes the following metrics: -// certificate_expiration_timestamp_seconds{name, namespace} -// certificate_renewal_timestamp_seconds{name, namespace} -// certificate_ready_status{name, namespace, condition} -// acme_client_request_count{"scheme", "host", "path", "method", "status"} -// acme_client_request_duration_seconds{"scheme", "host", "path", "method", "status"} -// controller_sync_call_count{"controller"} package metrics import ( diff --git a/pkg/metrics/certificates.go b/pkg/metrics/certificates.go index 3c3892472..4c5b7e427 100644 --- a/pkg/metrics/certificates.go +++ b/pkg/metrics/certificates.go @@ -14,14 +14,6 @@ See the License for the specific language governing permissions and limitations under the License. */ -// Package metrics contains global structures related to metrics collection -// cert-manager exposes the following metrics: -// certificate_expiration_timestamp_seconds{name, namespace} -// certificate_renewal_timestamp_seconds{name, namespace} -// certificate_ready_status{name, namespace, condition} -// acme_client_request_count{"scheme", "host", "path", "method", "status"} -// acme_client_request_duration_seconds{"scheme", "host", "path", "method", "status"} -// controller_sync_call_count{"controller"} package metrics import ( diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go index 54a7395e0..f4164bc68 100644 --- a/pkg/metrics/metrics.go +++ b/pkg/metrics/metrics.go @@ -21,6 +21,7 @@ limitations under the License. // certificate_ready_status{name, namespace, condition} // acme_client_request_count{"scheme", "host", "path", "method", "status"} // acme_client_request_duration_seconds{"scheme", "host", "path", "method", "status"} +// venafi_client_request_duration_seconds{"scheme", "host", "path", "method", "status"} // controller_sync_call_count{"controller"} package metrics diff --git a/pkg/metrics/venafi.go b/pkg/metrics/venafi.go index e921d2be0..5467b08ce 100644 --- a/pkg/metrics/venafi.go +++ b/pkg/metrics/venafi.go @@ -14,15 +14,6 @@ See the License for the specific language governing permissions and limitations under the License. */ -// Package metrics contains global structures related to metrics collection -// cert-manager exposes the following metrics: -// certificate_expiration_timestamp_seconds{name, namespace} -// certificate_renewal_timestamp_seconds{name, namespace} -// certificate_ready_status{name, namespace, condition} -// acme_client_request_count{"scheme", "host", "path", "method", "status"} -// acme_client_request_duration_seconds{"scheme", "host", "path", "method", "status"} -// venafi_client_request_duration_seconds{"scheme", "host", "path", "method", "status"} -// controller_sync_call_count{"controller"} package metrics import (