From 5679f6257f8380dd71fb3a37494daa23e2a2f1da Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Thu, 12 Apr 2018 19:31:29 +0100 Subject: [PATCH] Fix up self check failure error message --- pkg/issuer/acme/prepare.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/issuer/acme/prepare.go b/pkg/issuer/acme/prepare.go index ab209f0ec..4a7189b86 100644 --- a/pkg/issuer/acme/prepare.go +++ b/pkg/issuer/acme/prepare.go @@ -220,8 +220,9 @@ func (a *Acme) presentChallenge(ctx context.Context, cl client.Interface, crt *v return err } - // Error is only way to indicate that we are ready to ACME Accept challenge - return fmt.Errorf("% challenge was created for domain %q, waiting for propagation", ch.Type, ch.Domain) + // We return an error here instead of nil, as the only way for 'presentChallenge' + // to return without error is if the self check passes, which we check above. + return fmt.Errorf("%s self check failed for domain %q", ch.Type, ch.Domain) } func (a *Acme) cleanupLastOrder(ctx context.Context, crt *v1alpha1.Certificate) error {