From 878d84a2fac6372b0cc0d53c30a0c984ca25dfd6 Mon Sep 17 00:00:00 2001 From: Tristan Deloche Date: Tue, 20 Sep 2022 16:10:22 +0100 Subject: [PATCH 1/2] Ensure forward-compatibility with k8s.io/apiserver's Storage interface Signed-off-by: Tristan Deloche --- .../webhook/registry/challengepayload/challenge_payload.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/acme/webhook/registry/challengepayload/challenge_payload.go b/pkg/acme/webhook/registry/challengepayload/challenge_payload.go index 9de32f984..602f70384 100644 --- a/pkg/acme/webhook/registry/challengepayload/challenge_payload.go +++ b/pkg/acme/webhook/registry/challengepayload/challenge_payload.go @@ -100,3 +100,6 @@ func (r *REST) callSolver(req v1alpha1.ChallengeRequest) (v1alpha1.ChallengeResp }, }, nil } + +func (r *REST) Destroy() { +} From 99ed9f3e06aa5505dd272b7e7a6934d61e45889e Mon Sep 17 00:00:00 2001 From: Tim Ramlot <42113979+inteon@users.noreply.github.com> Date: Fri, 23 Sep 2022 10:30:32 +0200 Subject: [PATCH 2/2] add comment Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> --- .../webhook/registry/challengepayload/challenge_payload.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/acme/webhook/registry/challengepayload/challenge_payload.go b/pkg/acme/webhook/registry/challengepayload/challenge_payload.go index 602f70384..f202b8603 100644 --- a/pkg/acme/webhook/registry/challengepayload/challenge_payload.go +++ b/pkg/acme/webhook/registry/challengepayload/challenge_payload.go @@ -101,5 +101,9 @@ func (r *REST) callSolver(req v1alpha1.ChallengeRequest) (v1alpha1.ChallengeResp }, nil } +// This resource type isn't actually persisted anywhere, it is only submitted to the +// DNS01 solver webhooks, so there's nothing to do to delete a resource/it doesn't +// make sense in this context. +// see: https://github.com/cert-manager/cert-manager/pull/5346#discussion_r959521656 func (r *REST) Destroy() { }