From 474c8ed27fd4623577aacc3f05c95792b4223259 Mon Sep 17 00:00:00 2001 From: Louis Taylor Date: Wed, 25 Jul 2018 17:41:05 +0100 Subject: [PATCH] Add extra testcase --- .../validation/certificate_for_issuer_test.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/pkg/apis/certmanager/validation/certificate_for_issuer_test.go b/pkg/apis/certmanager/validation/certificate_for_issuer_test.go index af86ef623..d64adc0be 100644 --- a/pkg/apis/certmanager/validation/certificate_for_issuer_test.go +++ b/pkg/apis/certmanager/validation/certificate_for_issuer_test.go @@ -42,6 +42,17 @@ func TestValidateCertificateForACMEIssuer(t *testing.T) { KeyAlgorithm: v1alpha1.RSAKeyAlgorithm, }, }, + "certificate with incorrect keyAlgorithm for ACME": { + spec: &v1alpha1.CertificateSpec{ + CommonName: "testcn", + SecretName: "abc", + IssuerRef: validIssuerRef, + KeyAlgorithm: v1alpha1.ECDSAKeyAlgorithm, + }, + errs: []*field.Error{ + field.Invalid(fldPath.Child("keyAlgorithm"), v1alpha1.ECDSAKeyAlgorithm, "ACME key algorithm must be RSA"), + }, + }, } for n, s := range scenarios { t.Run(n, func(t *testing.T) {