diff --git a/internal/apis/certmanager/validation/certificate_test.go b/internal/apis/certmanager/validation/certificate_test.go index 4d3280cef..4a8285b51 100644 --- a/internal/apis/certmanager/validation/certificate_test.go +++ b/internal/apis/certmanager/validation/certificate_test.go @@ -944,6 +944,18 @@ func Test_validateLiteralSubject(t *testing.T) { }, a: someAdmissionRequest, }, + "valid with a `literalSubject` containing CN with special characters, multiple DC and well-known rfc4514 and rfc5280 RDN OIDs": { + featureEnabled: true, + cfg: &internalcmapi.Certificate{ + Spec: internalcmapi.CertificateSpec{ + Subject: &internalcmapi.X509Subject{SerialNumber: "1"}, + LiteralSubject: "CN=James \\\"Jim\\\" Smith\\, III,DC=dc,DC=net,UID=jamessmith,STREET=La Rambla,L=Barcelona,C=Spain,O=Acme,OU=IT,OU=Admins", + SecretName: "abc", + IssuerRef: validIssuerRef, + }, + }, + a: someAdmissionRequest, + }, "invalid with a `literalSubject` without CN and no dnsNames, ipAddresses, or emailAddress": { featureEnabled: true, cfg: &internalcmapi.Certificate{ diff --git a/make/e2e.sh b/make/e2e.sh index e3d167ba5..4468736d9 100755 --- a/make/e2e.sh +++ b/make/e2e.sh @@ -73,7 +73,7 @@ nodes=20 flake_attempts=1 ginkgo_skip= ginkgo_focus= -feature_gates=AdditionalCertificateOutputFormats=true,ExperimentalCertificateSigningRequestControllers=true,ExperimentalGatewayAPISupport=true +feature_gates=AdditionalCertificateOutputFormats=true,ExperimentalCertificateSigningRequestControllers=true,ExperimentalGatewayAPISupport=true,LiteralCertificateSubject=true artifacts="./$BINDIR/artifacts" help() { cat <