weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #6635 from SpectralHiss/hef/ensure-featuregate-in-othername-e2e

Browse Source 
Require feature gate in otherName SAN cert e2e
This commit is contained in:
jetstack-bot 2024-01-12 15:36:58 +00:00 committed by GitHub
commit 3d4c6d1a3b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/e2e/suite/certificates/othernamesan.go
View File

@ -25,8 +25,10 @@ import (
"github.com/cert-manager/cert-manager/e2e-tests/framework"
. "github.com/cert-manager/cert-manager/e2e-tests/framework/matcher"
e2eutil "github.com/cert-manager/cert-manager/e2e-tests/util"
"github.com/cert-manager/cert-manager/internal/webhook/feature"
cmapi "github.com/cert-manager/cert-manager/pkg/apis/certmanager/v1"
cmmeta "github.com/cert-manager/cert-manager/pkg/apis/meta/v1"
utilfeature "github.com/cert-manager/cert-manager/pkg/util/feature"
"github.com/cert-manager/cert-manager/test/unit/gen"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
@ -47,6 +49,7 @@ var _ = framework.CertManagerDescribe("othername san processing", func() {
)
f := framework.NewDefaultFramework("certificate-othername-san-processing")
createCertificate := func(f *framework.Framework, OtherNames []cmapi.OtherName) (*cmapi.Certificate, error) {
crt := &cmapi.Certificate{
ObjectMeta: metav1.ObjectMeta{
@ -69,6 +72,8 @@ var _ = framework.CertManagerDescribe("othername san processing", func() {
}
BeforeEach(func() {
framework.RequireFeatureGate(f, utilfeature.DefaultFeatureGate, feature.OtherNames)
By("creating a self-signing issuer")
issuer := gen.Issuer(issuerName,
gen.SetIssuerNamespace(f.Namespace.Name),