Document more info on CN behaviour

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>

deploy/charts/cert-manager/crds/certificates.yaml

@@ -65,10 +65,10 @@ spec:
           - secretName
           properties:
             commonName:
-              description: CommonName is a common name to be used on the Certificate.
+              description: 'CommonName is a common name to be used on the Certificate.
                 The CommonName should have a length of 64 characters or fewer to avoid
                 generating invalid CSRs. This value is ignored by TLS clients when
-                any subject alt name is set.
+                any subject alt name is set. This is x509 behaviour: https://tools.ietf.org/html/rfc6125#section-6.4.4'
               type: string
             dnsNames:
               description: DNSNames is a list of subject alt names to be used on the

deploy/manifests/00-crds.yaml

@@ -256,10 +256,10 @@ spec:
           - secretName
           properties:
             commonName:
-              description: CommonName is a common name to be used on the Certificate.
+              description: 'CommonName is a common name to be used on the Certificate.
                 The CommonName should have a length of 64 characters or fewer to avoid
                 generating invalid CSRs. This value is ignored by TLS clients when
-                any subject alt name is set.
+                any subject alt name is set. This is x509 behaviour: https://tools.ietf.org/html/rfc6125#section-6.4.4'
               type: string
             dnsNames:
               description: DNSNames is a list of subject alt names to be used on the

pkg/apis/certmanager/v1alpha2/types_certificate.go

@@ -80,6 +80,7 @@ type CertificateSpec struct {
 	// The CommonName should have a length of 64 characters or fewer to avoid
 	// generating invalid CSRs.
 	// This value is ignored by TLS clients when any subject alt name is set.
+	// This is x509 behaviour: https://tools.ietf.org/html/rfc6125#section-6.4.4
 	// +optional
 	CommonName string `json:"commonName,omitempty"`
 

pkg/apis/certmanager/v1alpha3/types_certificate.go

@@ -79,6 +79,8 @@ type CertificateSpec struct {
 	// CommonName is a common name to be used on the Certificate.
 	// The CommonName should have a length of 64 characters or fewer to avoid
 	// generating invalid CSRs.
+	// This value is ignored by TLS clients when any subject alt name is set.
+	// This is x509 behaviour: https://tools.ietf.org/html/rfc6125#section-6.4.4
 	// +optional
 	CommonName string `json:"commonName,omitempty"`
 

pkg/internal/venafi/BUILD.bazel

@@ -29,6 +29,7 @@ filegroup(
     name = "all-srcs",
     srcs = [
         ":package-srcs",
+        "//pkg/internal/venafi/api:all-srcs",
         "//pkg/internal/venafi/fake:all-srcs",
     ],
     tags = ["automanaged"],