weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #3793 from JoshVanL/dont-log-cr-deleted

Browse Source 
Don't log from multiple controllers when a CertificateRequest is deleted
This commit is contained in:
jetstack-bot 2021-03-24 13:27:46 +00:00 committed by GitHub
commit 3a367927dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/controller/certificaterequests/controller.go
View File

@ -18,6 +18,7 @@ package certificaterequests
import (
"context"
"fmt"
"github.com/go-logr/logr"
k8sErrors "k8s.io/apimachinery/pkg/api/errors"
@ -172,6 +173,8 @@ func (c *Controller) Register(ctx *controllerpkg.Context) (workqueue.RateLimitin
func (c *Controller) ProcessItem(ctx context.Context, key string) error {
log := logf.FromContext(ctx)
dbg := log.V(logf.DebugLevel)
namespace, name, err := cache.SplitMetaNamespaceKey(key)
if err != nil {
log.Error(err, "invalid resource key")
@ -181,7 +184,7 @@ func (c *Controller) ProcessItem(ctx context.Context, key string) error {
cr, err := c.certificateRequestLister.CertificateRequests(namespace).Get(name)
if err != nil {
if k8sErrors.IsNotFound(err) {
log.Error(err, "certificate request in work queue no longer exists")
dbg.Info(fmt.Sprintf("certificate request in work queue no longer exists: %s", err))
return nil
}