From 393e146543c4dea2ff27cc1fecf6995b964a38ac Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Thu, 22 Mar 2018 21:03:00 +0000 Subject: [PATCH] Fix arguments to ensureIngress --- pkg/issuer/acme/http/http.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/issuer/acme/http/http.go b/pkg/issuer/acme/http/http.go index d1edbbaf8..71673f48b 100644 --- a/pkg/issuer/acme/http/http.go +++ b/pkg/issuer/acme/http/http.go @@ -67,8 +67,11 @@ func NewSolver(issuer v1alpha1.GenericIssuer, client kubernetes.Interface, podLi // will return nil (i.e. this function is idempotent). func (s *Solver) Present(ctx context.Context, crt *v1alpha1.Certificate, domain, token, key string) error { _, podErr := s.ensurePod(crt, domain, token, key) - _, svcErr := s.ensureService(crt, domain, token, key) - _, ingressErr := s.ensureIngress(crt, domain, token, key) + svc, svcErr := s.ensureService(crt, domain, token, key) + if svcErr != nil { + return utilerrors.NewAggregate([]error{podErr, svcErr}) + } + _, ingressErr := s.ensureIngress(crt, svc.Name, domain, token) return utilerrors.NewAggregate([]error{podErr, svcErr, ingressErr}) }