Add argument check, example uses; cleanup

Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
This commit is contained in:
Haoxiang Zhou 2020-06-04 10:12:17 +01:00
parent 4dd0093cb6
commit 378521300a
2 changed files with 14 additions and 3 deletions

View File

@ -43,6 +43,14 @@ var (
Create a cert-manager CertificateRequest resource for one-time Certificate issuing without auto renewal.`))
example = templates.Examples(i18n.T(`
# Create a certificate request from from file.
kubectl cert-manager create certificaterequest -f my-certificate.yaml
# Create a certificate request in namespace sandbox, provided no conflict with namesapce defined in file.
kubectl cert-manager create certificaterequest --namespace sandbox -f my-certificate.yaml
# Create a certificate request with the name 'my-cr'.
kubectl cert-manager create certificaterequest -f my-certificate.yaml my-cr
`))
alias = []string{"cr"}
@ -83,6 +91,12 @@ func NewCmdCreateCertficate(ioStreams genericclioptions.IOStreams, factory cmdut
Short: "Create a CertificateRequest resource",
Long: long,
Example: example,
Args: func(cmd *cobra.Command, args []string) error {
if len(args) > 1 {
return fmt.Errorf("only one argument can be passed in as the name of the certificate request")
}
return nil
},
Run: func(cmd *cobra.Command, args []string) {
cmdutil.CheckErr(o.Complete(factory))
cmdutil.CheckErr(o.Run(args))

View File

@ -28,9 +28,6 @@ func NewCmdCreate(ioStreams genericclioptions.IOStreams, factory cmdutil.Factory
Short: "Create something",
Long: `Create something e.g. CertificateRequest`,
}
//cmds.SetUsageTemplate(usageTemplate)
// TODO: add flags
cmds.AddCommand(NewCmdCreateCertficate(ioStreams, factory))