From 3761c6c3a4f01a882957fa0c19a84b251201628d Mon Sep 17 00:00:00 2001
From: splashx <splash@gmail.com>
Date: Mon, 10 Sep 2018 21:40:40 +0200
Subject: [PATCH] fix panic, wrong logic

Signed-off-by: splashx <splash@gmail.com>
---
 pkg/issuer/acme/dns/rfc2136/rfc2136.go | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/pkg/issuer/acme/dns/rfc2136/rfc2136.go b/pkg/issuer/acme/dns/rfc2136/rfc2136.go
index 01d505641..2e883f20e 100644
--- a/pkg/issuer/acme/dns/rfc2136/rfc2136.go
+++ b/pkg/issuer/acme/dns/rfc2136/rfc2136.go
@@ -125,11 +125,10 @@ func NewDNSProviderCredentials(nameserver, tsigAlgorithm, tsigKeyName, tsigSecre
 
 	d := &DNSProvider{}
 
-	validNameserver, err := ValidNameserver(nameserver)
-	if err != nil {
-		d.nameserver = validNameserver
-	} else {
+	if validNameserver, err := ValidNameserver(nameserver); err != nil {
 		return nil, err
+	} else {
+		d.nameserver = validNameserver
 	}
 
 	if len(tsigKeyName) > 0 && len(tsigSecret) > 0 {