From 2c2fbd483b83d8a2fb00f2f2505717823b5b44d7 Mon Sep 17 00:00:00 2001 From: clatour Date: Tue, 20 Apr 2021 22:06:24 +0000 Subject: [PATCH] Add a more descriptive FindZoneByFqdn error message Spent a couple of days tracking down bad `SERVFAIL` for some of our domains, and had a hard time finding where this was coming from. Make the error slightly more descriptive to help locate it, and more inline with the terminal error of the function. Signed-off-by: clatour --- pkg/issuer/acme/dns/util/wait.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/issuer/acme/dns/util/wait.go b/pkg/issuer/acme/dns/util/wait.go index db10a3bd7..602140cfc 100644 --- a/pkg/issuer/acme/dns/util/wait.go +++ b/pkg/issuer/acme/dns/util/wait.go @@ -342,7 +342,7 @@ func FindZoneByFqdn(fqdn string, nameservers []string) (string, error) { // Any response code other than NOERROR and NXDOMAIN is treated as error if in.Rcode != dns.RcodeNameError && in.Rcode != dns.RcodeSuccess { - return "", fmt.Errorf("Unexpected response code '%s' for %s", + return "", fmt.Errorf("Could not find the start of authority, unexpected response code '%s' for %s", dns.RcodeToString[in.Rcode], domain) }