diff --git a/pkg/issuer/acme/dns/acmedns/acmedns_test.go b/pkg/issuer/acme/dns/acmedns/acmedns_test.go index 4645c90ae..9c6e616a1 100644 --- a/pkg/issuer/acme/dns/acmedns/acmedns_test.go +++ b/pkg/issuer/acme/dns/acmedns/acmedns_test.go @@ -50,21 +50,19 @@ func TestValidJsonAccount(t *testing.T) { }`) provider, err := NewDNSProviderHostBytes("http://localhost/", accountJson, util.RecursiveNameservers) assert.NoError(t, err, "Expected no error constructing DNSProvider") - - assert.NoError(t, err, "Expected account to be set from JSON") assert.Equal(t, provider.accounts["domain"].FullDomain, "fooldom") } func TestNoValidJsonAccount(t *testing.T) { accountJson := []byte(`{"duck": "quack"}`) _, err := NewDNSProviderHostBytes("http://localhost/", accountJson, util.RecursiveNameservers) - assert.Error(t, err, "Expected no error constructing DNSProvider") + assert.Error(t, err, "Expected error constructing DNSProvider from invalid accountJson") } func TestNoValidJson(t *testing.T) { accountJson := []byte("b00m") _, err := NewDNSProviderHostBytes("http://localhost/", accountJson, util.RecursiveNameservers) - assert.Error(t, err, "Expected no error constructing DNSProvider") + assert.Error(t, err, "Expected error constructing DNSProvider from invalid JSON") } func TestLiveAcmeDnsPresent(t *testing.T) { diff --git a/pkg/issuer/acme/dns/dns_test.go b/pkg/issuer/acme/dns/dns_test.go index e5b215ac3..ebabc20b6 100644 --- a/pkg/issuer/acme/dns/dns_test.go +++ b/pkg/issuer/acme/dns/dns_test.go @@ -214,7 +214,7 @@ func TestSolverFor(t *testing.T) { Builder: &test.Builder{ KubeObjects: []runtime.Object{ newSecret("acmedns-key", "default", map[string][]byte{ - "acmedns.json": []byte("{x}"), + "acmedns.json": []byte("{}"), }), }, },