weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Adds tests to ensure Approve is present, and Denied is not

Browse Source 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
This commit is contained in:
joshvanl 2021-03-08 13:35:23 +00:00
parent a3e63b1787
commit 1235ff3bef
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/e2e/framework/helper/certificaterequests.go
View File

@ -186,8 +186,11 @@ func (h *Helper) ValidateIssuedCertificateRequest(cr *cmapi.CertificateRequest,
}
}
if !apiutil.CertificateRequestHasApproved(cr) {
return nil, fmt.Errorf("CertificateRequest does not have an Approved condition: %+v", cr.Status.Conditions)
if !apiutil.CertificateRequestIsApproved(cr) {
return nil, fmt.Errorf("CertificateRequest does not have an Approved condition set to True: %+v", cr.Status.Conditions)
}
if apiutil.CertificateRequestIsDenied(cr) {
return nil, fmt.Errorf("CertificateRequest has a Denied conditon set to True: %+v", cr.Status.Conditions)
}
return cert, nil

6
test/unit/gen/certificaterequest.go
View File

@ -96,6 +96,12 @@ func SetCertificateRequestStatusCondition(c v1.CertificateRequestCondition) Cert
}
}
func AddCertificateRequestStatusCondition(c v1.CertificateRequestCondition) CertificateRequestModifier {
return func(cr *v1.CertificateRequest) {
cr.Status.Conditions = append(cr.Status.Conditions, c)
}
}
func SetCertificateRequestNamespace(namespace string) CertificateRequestModifier {
return func(cr *v1.CertificateRequest) {
cr.ObjectMeta.Namespace = namespace