Add critical extension to only SAN

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-21 12:06:33 +00:00 · 2023-12-21 12:06:33 +00:00 · 120240fec2
commit 120240fec2
parent 8e2365dd54
2 changed files with 6 additions and 4 deletions
--- a/test/e2e/suite/certificates/othernamesan.go
+++ b/test/e2e/suite/certificates/othernamesan.go
@ -147,6 +147,7 @@ var _ = framework.CertManagerDescribe("othername san processing", func() {
 			return pkix.Extension{
 				Id:       oidExtensionSubjectAltName,
 				Value:    val,
+				Critical: true,
 			}
 		}
 		expectedSanExtension := mustMarshalSAN([]asn1.RawValue{
--- a/test/e2e/suite/conformance/certificates/tests.go
+++ b/test/e2e/suite/conformance/certificates/tests.go
@ -306,6 +306,7 @@ func (s *Suite) Define() {
 					return pkix.Extension{
 						Id:       oidExtensionSubjectAltName,
 						Value:    val,
+						Critical: true, // Since there is no subject the SAN extension is critical
 					}
 				}
 				nameTypeEmail := 1