weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

improve tests based on review

Browse Source 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
This commit is contained in:
Tim Ramlot 2024-05-10 20:43:54 +02:00
parent 9d1c959a1e
commit 0a45298971
No known key found for this signature in database
GPG Key ID: 47428728E0C2878D
1 changed files with 40 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
pkg/util/pki/subject_test.go
View File

@ -120,39 +120,56 @@ func TestShouldFailForHexDER(t *testing.T) {
// TestRoundTripRDNSequence tests a set of RDNSequences to ensure that they are // TestRoundTripRDNSequence tests a set of RDNSequences to ensure that they are
// the same after a round trip through String() and UnmarshalSubjectStringToRDNSequence(). // the same after a round trip through String() and UnmarshalSubjectStringToRDNSequence().
func TestRoundTripRDNSequence(t *testing.T) { func TestRoundTripRDNSequence(t *testing.T) {
rdnSequences := []pkix.RDNSequence{ type testCase struct {
name string
rdn pkix.RDNSequence
}
rdnSequences := []testCase{
{ {
[]pkix.AttributeTypeAndValue{ name: "Simple RDNSequence",
{Type: OIDConstants.Organization, Value: "Corp."}, rdn: pkix.RDNSequence{
{Type: OIDConstants.OrganizationalUnit, Value: "FooLong"}, []pkix.AttributeTypeAndValue{
{Type: OIDConstants.Organization, Value: "Corp."},
{Type: OIDConstants.OrganizationalUnit, Value: "FooLong"},
},
}, },
}, },
{ {
[]pkix.AttributeTypeAndValue{ name: "Character Escaping",
{Type: OIDConstants.CommonName, Value: "foo-lon❤️\\g.com "}, rdn: pkix.RDNSequence{
{Type: OIDConstants.OrganizationalUnit, Value: "Foo===Long"}, []pkix.AttributeTypeAndValue{
{Type: OIDConstants.OrganizationalUnit, Value: "Ba rq"}, {Type: OIDConstants.CommonName, Value: "foo-lon❤️\\g.com "},
{Type: OIDConstants.OrganizationalUnit, Value: "Baz"}, {Type: OIDConstants.OrganizationalUnit, Value: "Foo===Long"},
}, {Type: OIDConstants.OrganizationalUnit, Value: "Ba rq"},
[]pkix.AttributeTypeAndValue{ {Type: OIDConstants.OrganizationalUnit, Value: "Baz"},
{Type: OIDConstants.Organization, Value: "C; orp."}, {Type: OIDConstants.Country, Value: "fo\x00o-long.com"},
{Type: OIDConstants.Country, Value: "US"}, },
[]pkix.AttributeTypeAndValue{
{Type: OIDConstants.Organization, Value: "C; orp."},
{Type: OIDConstants.Country, Value: "US"},
},
}, },
}, },
{ {
[]pkix.AttributeTypeAndValue{ name: "Numeric OID",
{Type: asn1.ObjectIdentifier{0, 5, 80, 99, 58962185}, Value: "fo\x00o-long.com"}, rdn: pkix.RDNSequence{
[]pkix.AttributeTypeAndValue{
{Type: asn1.ObjectIdentifier{0, 5, 80, 99, 58962185}, Value: "String Value"},
},
}, },
}, },
} }
for _, rdnSeq := range rdnSequences { for _, tc := range rdnSequences {
newRDNSeq, err := UnmarshalSubjectStringToRDNSequence(rdnSeq.String()) tc := tc
if err != nil { t.Run(tc.name, func(t *testing.T) {
t.Fatal(err) newRDNSeq, err := UnmarshalSubjectStringToRDNSequence(tc.rdn.String())
} if err != nil {
t.Fatal(err)
}
assert.Equal(t, rdnSeq, newRDNSeq) assert.Equal(t, tc.rdn, newRDNSeq)
})
} }
} }
@ -164,6 +181,8 @@ func FuzzRoundTripRDNSequence(f *testing.F) {
f.Add("CN=foo-long.com,OU=FooLong,OU=Barq,OU=Baz,OU=Dept.,O=Corp.,C=US") f.Add("CN=foo-long.com,OU=FooLong,OU=Barq,OU=Baz,OU=Dept.,O=Corp.,C=US")
f.Add("CN=foo-lon❤️\\,g.com,OU=Foo===Long,OU=Ba # rq,OU=Baz,O=C\\; orp.,C=US") f.Add("CN=foo-lon❤️\\,g.com,OU=Foo===Long,OU=Ba # rq,OU=Baz,O=C\\; orp.,C=US")
f.Add("CN=fo\x00o-long.com,OU=\x04FooLong") f.Add("CN=fo\x00o-long.com,OU=\x04FooLong")
f.Add("1.2.3.4=String Value")
f.Add("1.3.6.1.4.1.1466.0=#04024869")
f.Fuzz(func(t *testing.T, subjectString string) { f.Fuzz(func(t *testing.T, subjectString string) {
t.Parallel() t.Parallel()