From 03c6f1229f650e2be57b588ae1d996d15d63287c Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Tue, 16 Oct 2018 12:28:37 +0100 Subject: [PATCH] Remove unused arg from GenerateTemplate Signed-off-by: James Munnelly --- pkg/issuer/ca/issue.go | 2 +- pkg/issuer/selfsigned/issue.go | 2 +- pkg/util/pki/csr.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/issuer/ca/issue.go b/pkg/issuer/ca/issue.go index 656665a4a..e4983c1ca 100644 --- a/pkg/issuer/ca/issue.go +++ b/pkg/issuer/ca/issue.go @@ -111,7 +111,7 @@ func (c *CA) obtainCertificate(crt *v1alpha1.Certificate, signeeKey interface{}, return nil, fmt.Errorf("error getting issuer private key: %s", err.Error()) } - template, err := pki.GenerateTemplate(c.issuer, crt, nil) + template, err := pki.GenerateTemplate(c.issuer, crt) if err != nil { return nil, err } diff --git a/pkg/issuer/selfsigned/issue.go b/pkg/issuer/selfsigned/issue.go index e65dd7423..2ef2d7236 100644 --- a/pkg/issuer/selfsigned/issue.go +++ b/pkg/issuer/selfsigned/issue.go @@ -91,7 +91,7 @@ func (c *SelfSigned) obtainCertificate(crt *v1alpha1.Certificate, privateKey cry return nil, err } - template, err := pki.GenerateTemplate(c.issuer, crt, nil) + template, err := pki.GenerateTemplate(c.issuer, crt) if err != nil { return nil, err } diff --git a/pkg/util/pki/csr.go b/pkg/util/pki/csr.go index e0b48391e..b27345a7a 100644 --- a/pkg/util/pki/csr.go +++ b/pkg/util/pki/csr.go @@ -100,7 +100,7 @@ func GenerateCSR(issuer v1alpha1.GenericIssuer, crt *v1alpha1.Certificate) (*x50 // This should create a Certificate template that is equivalent to the CertificateRequest // generated by GenerateCSR. // The PublicKey field must be populated by the caller. -func GenerateTemplate(issuer v1alpha1.GenericIssuer, crt *v1alpha1.Certificate, serialNo *big.Int) (*x509.Certificate, error) { +func GenerateTemplate(issuer v1alpha1.GenericIssuer, crt *v1alpha1.Certificate) (*x509.Certificate, error) { commonName := CommonNameForCertificate(crt) dnsNames := DNSNamesForCertificate(crt) organization := OrganizationForCertificate(crt)