From c1249c9cf230af2b36a1883d5f919dae848c1a53 Mon Sep 17 00:00:00 2001 From: "Patrick J. McNerthney" Date: Mon, 7 Sep 2020 19:43:09 -1000 Subject: [PATCH] Support both python 2.7 and 3.x. --- examples/pod_portforward.py | 7 ++++--- kubernetes/e2e_test/test_client.py | 9 +++++---- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/examples/pod_portforward.py b/examples/pod_portforward.py index aa95ada3e..9793fd311 100644 --- a/examples/pod_portforward.py +++ b/examples/pod_portforward.py @@ -19,7 +19,8 @@ Shows the functionality of portforward streaming using an nginx container. import select import socket import time -import urllib.request + +import six.moves.urllib.request as urllib_request from kubernetes import config from kubernetes.client import Configuration @@ -179,11 +180,11 @@ def portforward_commands(api_instance): # Access the nginx http server using the # ".pod..kubernetes" dns name. - response = urllib.request.urlopen( + response = urllib_request.urlopen( 'http://%s.pod.default.kubernetes' % name) html = response.read().decode('utf-8') response.close() - print('Status:', response.status) + print('Status Code: %s' % response.code) print(html) diff --git a/kubernetes/e2e_test/test_client.py b/kubernetes/e2e_test/test_client.py index 95977b21b..00e46a377 100644 --- a/kubernetes/e2e_test/test_client.py +++ b/kubernetes/e2e_test/test_client.py @@ -17,7 +17,6 @@ import select import socket import time import unittest -import urllib.request import uuid from kubernetes.client import api_client @@ -26,6 +25,7 @@ from kubernetes.e2e_test import base from kubernetes.stream import stream, portforward from kubernetes.stream.ws_client import ERROR_CHANNEL +import six.moves.urllib.request as urllib_request def short_uuid(): id = str(uuid.uuid4()) @@ -228,7 +228,7 @@ class TestClient(unittest.TestCase): self.assertTrue(pf.connected) sock = pf.socket(1236) - self.assertRaises(BrokenPipeError, sock.sendall, b'This should fail...') + self.assertRaises(socket.error, sock.sendall, b'This should fail...') self.assertIsNotNone(pf.error(1236)) sock.close() @@ -246,6 +246,7 @@ class TestClient(unittest.TestCase): reply += data self.assertEqual(reply, sent) sock.close() + time.sleep(1) self.assertFalse(pf.connected) self.assertIsNone(pf.error(1234)) self.assertIsNone(pf.error(1235)) @@ -300,12 +301,12 @@ class TestClient(unittest.TestCase): socket_create_connection = socket.create_connection try: socket.create_connection = kubernetes_create_connection - response = urllib.request.urlopen('http://%s.default.kubernetes/' % name) + response = urllib_request.urlopen('http://%s.default.kubernetes/' % name) html = response.read().decode('utf-8') finally: socket.create_connection = socket_create_connection - self.assertEqual(response.status, 200) + self.assertEqual(response.code, 200) self.assertTrue('

Welcome to nginx!

' in html) resp = api.delete_namespaced_pod(name=name, body={},