From 7bb08512177471eb9a6245479478dd989f8a76c6 Mon Sep 17 00:00:00 2001 From: Prabha <58968096+zidhumenon@users.noreply.github.com> Date: Sun, 18 Apr 2021 16:14:24 +0530 Subject: [PATCH 1/7] Fix issue #1395 create_job function was not printing the current status of the job. Modified the create_job function to call read_namespaced_job_status in order to get the current job status --- examples/job_crud.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/examples/job_crud.py b/examples/job_crud.py index b18b152d4..e25f330d6 100644 --- a/examples/job_crud.py +++ b/examples/job_crud.py @@ -20,6 +20,8 @@ from os import path import yaml +from time import sleep + from kubernetes import client, config JOB_NAME = "pi" @@ -53,7 +55,16 @@ def create_job(api_instance, job): api_response = api_instance.create_namespaced_job( body=job, namespace="default") - print("Job created. status='%s'" % str(api_response.status)) + # Need to wait for a second for the job status to update + sleep(1) + print("Job created. status='%s'" % str(get_job_status(api_instance))) + + +def get_job_status(api_instance): + api_response = api_instance.read_namespaced_job_status( + name=JOB_NAME, + namespace="default") + return api_response.status def update_job(api_instance, job): From 7571b4519e54e2e747a21f7f900e486ccee19aa0 Mon Sep 17 00:00:00 2001 From: Prabha <58968096+steveprabha@users.noreply.github.com> Date: Sun, 2 May 2021 21:38:37 +0530 Subject: [PATCH 2/7] Update job_crud.py --- examples/job_crud.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/job_crud.py b/examples/job_crud.py index e25f330d6..ea454aea9 100644 --- a/examples/job_crud.py +++ b/examples/job_crud.py @@ -55,15 +55,17 @@ def create_job(api_instance, job): api_response = api_instance.create_namespaced_job( body=job, namespace="default") - # Need to wait for a second for the job status to update - sleep(1) print("Job created. status='%s'" % str(get_job_status(api_instance))) def get_job_status(api_instance): - api_response = api_instance.read_namespaced_job_status( - name=JOB_NAME, - namespace="default") + job_completed = False + while not job_completed: + api_response = api_instance.read_namespaced_job_status( + name=JOB_NAME, + namespace="default") + if api_response.status.succeeded is not None or api_response.status.failed is not None: + job_completed = True return api_response.status From 370eb798f41961caba873f067a8bfffb4feab736 Mon Sep 17 00:00:00 2001 From: Prabha <58968096+steveprabha@users.noreply.github.com> Date: Tue, 4 May 2021 14:02:00 +0530 Subject: [PATCH 3/7] Update job_crud.py --- examples/job_crud.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/job_crud.py b/examples/job_crud.py index ea454aea9..c12e40871 100644 --- a/examples/job_crud.py +++ b/examples/job_crud.py @@ -55,7 +55,8 @@ def create_job(api_instance, job): api_response = api_instance.create_namespaced_job( body=job, namespace="default") - print("Job created. status='%s'" % str(get_job_status(api_instance))) + print("Job created. status='%s'" % str(api_response.status)) + print("Job status='%s'" % str(get_job_status(api_instance))) def get_job_status(api_instance): @@ -66,6 +67,7 @@ def get_job_status(api_instance): namespace="default") if api_response.status.succeeded is not None or api_response.status.failed is not None: job_completed = True + sleep(1) return api_response.status From ecd1fb4b97faaddc2d61ddbe4d17272783ff0b8e Mon Sep 17 00:00:00 2001 From: Prabha <58968096+steveprabha@users.noreply.github.com> Date: Fri, 7 May 2021 17:26:14 +0530 Subject: [PATCH 4/7] Update job_crud.py --- examples/job_crud.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/job_crud.py b/examples/job_crud.py index c12e40871..23282bd91 100644 --- a/examples/job_crud.py +++ b/examples/job_crud.py @@ -56,7 +56,8 @@ def create_job(api_instance, job): body=job, namespace="default") print("Job created. status='%s'" % str(api_response.status)) - print("Job status='%s'" % str(get_job_status(api_instance))) + get_job_status(api_instance) + def get_job_status(api_instance): @@ -68,7 +69,7 @@ def get_job_status(api_instance): if api_response.status.succeeded is not None or api_response.status.failed is not None: job_completed = True sleep(1) - return api_response.status + print("Job status='%s'" % str(api_response.status)) def update_job(api_instance, job): From 57ad5d237e3e4640c6cba34e9ba0a017ced72b02 Mon Sep 17 00:00:00 2001 From: Prabha <58968096+steveprabha@users.noreply.github.com> Date: Tue, 11 May 2021 14:13:27 +0530 Subject: [PATCH 5/7] Update job_crud.py --- examples/job_crud.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/job_crud.py b/examples/job_crud.py index 23282bd91..7142e9e4c 100644 --- a/examples/job_crud.py +++ b/examples/job_crud.py @@ -59,14 +59,14 @@ def create_job(api_instance, job): get_job_status(api_instance) - def get_job_status(api_instance): job_completed = False while not job_completed: api_response = api_instance.read_namespaced_job_status( name=JOB_NAME, namespace="default") - if api_response.status.succeeded is not None or api_response.status.failed is not None: + if api_response.status.succeeded is not None or \ + api_response.status.failed is not None: job_completed = True sleep(1) print("Job status='%s'" % str(api_response.status)) From a06bd3a3c9d61084120b9940b61844606d72b544 Mon Sep 17 00:00:00 2001 From: Prabha <58968096+steveprabha@users.noreply.github.com> Date: Wed, 12 May 2021 11:45:52 +0530 Subject: [PATCH 6/7] Update job_crud.py --- examples/job_crud.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/examples/job_crud.py b/examples/job_crud.py index 7142e9e4c..2174ef73c 100644 --- a/examples/job_crud.py +++ b/examples/job_crud.py @@ -17,10 +17,9 @@ Creates, updates, and deletes a job object. """ from os import path - -import yaml - from time import sleep + +import yaml from kubernetes import client, config From 30477c7766597f3313faac274c08ace5762396ef Mon Sep 17 00:00:00 2001 From: Prabha <58968096+steveprabha@users.noreply.github.com> Date: Fri, 14 May 2021 00:44:53 +0530 Subject: [PATCH 7/7] Update job_crud.py --- examples/job_crud.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/job_crud.py b/examples/job_crud.py index 2174ef73c..ab02761a7 100644 --- a/examples/job_crud.py +++ b/examples/job_crud.py @@ -18,7 +18,7 @@ Creates, updates, and deletes a job object. from os import path from time import sleep - + import yaml from kubernetes import client, config