From d44caec2774e2091555182a1ab2796ce2635627c Mon Sep 17 00:00:00 2001 From: Nico Poggi Date: Fri, 19 Oct 2018 17:33:34 +0200 Subject: [PATCH] Revert "Update Scala Logging to officially supported one " (#172) Reverts #157 due to library errors when the previous was is in the classpath already (i.e., in databricks) and not bringing any noted improvements or needed fixes. Exception: java.lang.InstantiationError: com.typesafe.scalalogging.Logger This reverts commit 56f7348. --- build.sbt | 2 +- .../scala/com/databricks/spark/sql/perf/Benchmarkable.scala | 2 +- .../databricks/spark/sql/perf/mllib/BenchmarkAlgorithm.scala | 2 +- src/main/scala/com/databricks/spark/sql/perf/mllib/MLLib.scala | 2 +- .../spark/sql/perf/mllib/MLPipelineStageBenchmarkable.scala | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/build.sbt b/build.sbt index c019d81..654f155 100644 --- a/build.sbt +++ b/build.sbt @@ -42,7 +42,7 @@ libraryDependencies += "org.scalatest" %% "scalatest" % "2.2.1" % "test" libraryDependencies += "org.yaml" % "snakeyaml" % "1.17" -libraryDependencies += "com.typesafe.scala-logging" %% "scala-logging" % "3.9.0" +libraryDependencies += "com.typesafe.scala-logging" %% "scala-logging-slf4j" % "2.1.2" resolvers += "Apache Development Snapshot Repository" at "https://repository.apache.org/content/repositories/snapshots" diff --git a/src/main/scala/com/databricks/spark/sql/perf/Benchmarkable.scala b/src/main/scala/com/databricks/spark/sql/perf/Benchmarkable.scala index 5a5e0ff..62b12ea 100644 --- a/src/main/scala/com/databricks/spark/sql/perf/Benchmarkable.scala +++ b/src/main/scala/com/databricks/spark/sql/perf/Benchmarkable.scala @@ -18,7 +18,7 @@ package com.databricks.spark.sql.perf import java.util.UUID -import com.typesafe.scalalogging.{LazyLogging => Logging} +import com.typesafe.scalalogging.slf4j.{LazyLogging => Logging} import scala.concurrent.duration._ import scala.collection.mutable.ArrayBuffer diff --git a/src/main/scala/com/databricks/spark/sql/perf/mllib/BenchmarkAlgorithm.scala b/src/main/scala/com/databricks/spark/sql/perf/mllib/BenchmarkAlgorithm.scala index 77cf84a..986b1a8 100644 --- a/src/main/scala/com/databricks/spark/sql/perf/mllib/BenchmarkAlgorithm.scala +++ b/src/main/scala/com/databricks/spark/sql/perf/mllib/BenchmarkAlgorithm.scala @@ -1,6 +1,6 @@ package com.databricks.spark.sql.perf.mllib -import com.typesafe.scalalogging.{LazyLogging => Logging} +import com.typesafe.scalalogging.slf4j.{LazyLogging => Logging} import org.apache.spark.ml.attribute.{NominalAttribute, NumericAttribute} import org.apache.spark.ml.{Estimator, PipelineStage, Transformer} import org.apache.spark.ml.evaluation.Evaluator diff --git a/src/main/scala/com/databricks/spark/sql/perf/mllib/MLLib.scala b/src/main/scala/com/databricks/spark/sql/perf/mllib/MLLib.scala index 44c4b7e..d325327 100644 --- a/src/main/scala/com/databricks/spark/sql/perf/mllib/MLLib.scala +++ b/src/main/scala/com/databricks/spark/sql/perf/mllib/MLLib.scala @@ -4,7 +4,7 @@ package com.databricks.spark.sql.perf.mllib import scala.io.Source import scala.language.implicitConversions -import com.typesafe.scalalogging.{LazyLogging => Logging} +import com.typesafe.scalalogging.slf4j.{LazyLogging => Logging} import org.apache.spark.sql.{DataFrame, SQLContext} import org.apache.spark.{SparkConf, SparkContext} diff --git a/src/main/scala/com/databricks/spark/sql/perf/mllib/MLPipelineStageBenchmarkable.scala b/src/main/scala/com/databricks/spark/sql/perf/mllib/MLPipelineStageBenchmarkable.scala index 0d87310..2ccd78d 100644 --- a/src/main/scala/com/databricks/spark/sql/perf/mllib/MLPipelineStageBenchmarkable.scala +++ b/src/main/scala/com/databricks/spark/sql/perf/mllib/MLPipelineStageBenchmarkable.scala @@ -3,7 +3,7 @@ package com.databricks.spark.sql.perf.mllib import scala.collection.mutable.ArrayBuffer import scala.util.control.NonFatal -import com.typesafe.scalalogging.{LazyLogging => Logging} +import com.typesafe.scalalogging.slf4j.{LazyLogging => Logging} import org.apache.spark.ml.{Estimator, Transformer} import org.apache.spark.sql._