github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#10807] Meta.migrateTo(Meta) should not produce any diff when

Browse Source 
timestamp default precision is specified
This commit is contained in:
Lukas Eder 2020-10-28 17:35:54 +01:00
parent 92a9549e90
commit ffc0311f67
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
jOOQ/src/main/java/org/jooq/impl/Diff.java
View File

@ -427,27 +427,29 @@ final class Diff {
private final boolean precisionDifference(DataType<?> type1, DataType<?> type2) {
// [#10807] One type has an implicit default precision
return type1.precisionDefined() != type2.precisionDefined()
// [#10807] Only one type has a default precision defined
boolean d1 = defaultPrecision(type1);
boolean d2 = defaultPrecision(type2);
// ... and the other type has an explicit default precision
&& !defaultPrecision(type1)
&& !defaultPrecision(type2)
|| type1.precision() != type2.precision();
if (d1 || d2)
return d1 != d2;
else
return type1.precision() != type2.precision();
}
private final boolean defaultPrecision(DataType<?> type) {
if (!type.isDateTime())
return false;
if (!type.precisionDefined())
return true;
if (FALSE.equals(ctx.settings().isMigrationIgnoreDefaultTimestampPrecisionDiffs()))
return false;
switch (ctx.family()) {
case POSTGRES:
// [#10807] TODO: Alternative defaults will be listed here as they are discovered
default:
return type.precision() == 6;
}