github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#4333] Firebird CREATE TABLE regression when columns are nullable

Browse Source
This commit is contained in:
lukaseder 2015-05-30 11:47:33 +02:00
parent 9ac2503aff
commit ff09bb70b0
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
jOOQ/src/main/java/org/jooq/CreateTableAsStep.java
View File

@ -45,7 +45,6 @@ package org.jooq;
import static org.jooq.SQLDialect.CUBRID;
// ...
import static org.jooq.SQLDialect.DERBY;
import static org.jooq.SQLDialect.FIREBIRD;
import static org.jooq.SQLDialect.H2;
// ...
import static org.jooq.SQLDialect.HSQLDB;
@ -67,7 +66,7 @@ public interface CreateTableAsStep<R extends Record> {
/**
* Add an <code>AS</code> clause to the <code>CREATE TABLE</code> statement.
*/
@Support({ CUBRID, DERBY, FIREBIRD, H2, HSQLDB, MARIADB, MYSQL, POSTGRES, SQLITE })
@Support({ CUBRID, DERBY, H2, HSQLDB, MARIADB, MYSQL, POSTGRES, SQLITE })
CreateTableOnCommitStep as(Select<? extends R> select);
/**

3
jOOQ/src/main/java/org/jooq/SelectIntoStep.java
View File

@ -44,7 +44,6 @@ package org.jooq;
// ...
import static org.jooq.SQLDialect.CUBRID;
// ...
import static org.jooq.SQLDialect.DERBY;
import static org.jooq.SQLDialect.H2;
// ...
import static org.jooq.SQLDialect.HSQLDB;
@ -104,6 +103,6 @@ public interface SelectIntoStep<R extends Record> extends SelectFromStep<R> {
/**
* Add an <code>INTO</code> clause to the <code>SELECT</code> statement.
*/
@Support({ CUBRID, DERBY, H2, HSQLDB, MARIADB, MYSQL, POSTGRES, SQLITE })
@Support({ CUBRID, H2, HSQLDB, MARIADB, MYSQL, POSTGRES, SQLITE })
SelectIntoStep<Record> into(Table<?> table);
}

3
jOOQ/src/main/java/org/jooq/impl/CreateTableImpl.java
View File

@ -48,6 +48,7 @@ import static org.jooq.Clause.CREATE_TABLE_NAME;
// ...
// ...
import static org.jooq.SQLDialect.DERBY;
import static org.jooq.SQLDialect.FIREBIRD;
// ...
import static org.jooq.SQLDialect.POSTGRES;
// ...
@ -183,7 +184,7 @@ class CreateTableImpl<R extends Record> extends AbstractQuery implements
if (type.nullable()) {
// [#4321] Not all dialects support explicit NULL type declarations
if (!asList(DERBY).contains(ctx.family()))
if (!asList(DERBY, FIREBIRD).contains(ctx.family()))
ctx.sql(' ').keyword("null");
}
else {