From fb9f95d35c481c55e24903d5b2a7013f98aa1cbb Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Tue, 12 Oct 2021 09:55:01 +0200 Subject: [PATCH] [jOOQ/jOOQ#12506] SQLDialect.supportedBy() and supportedUntil() should specify that they're inclusive in their Javadoc --- jOOQ/src/main/java/org/jooq/SQLDialect.java | 15 ++++++---- jOOQ/src/main/java/org/jooq/impl/Pivot.java | 32 +++++++++++++++++++-- 2 files changed, 39 insertions(+), 8 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/SQLDialect.java b/jOOQ/src/main/java/org/jooq/SQLDialect.java index 4a7a07b273..4ac42f06f5 100644 --- a/jOOQ/src/main/java/org/jooq/SQLDialect.java +++ b/jOOQ/src/main/java/org/jooq/SQLDialect.java @@ -866,7 +866,8 @@ public enum SQLDialect { * Get a set of dialects preceding a given set of dialects. *

* The resulting set of dialects contain all the families and dialect - * versions that precede the argument dialects. + * versions that precede the argument dialects, including the argument + * dialects. */ @NotNull public static final Set predecessors(SQLDialect... dialects) { @@ -883,7 +884,8 @@ public enum SQLDialect { * version. *

* The resulting set of dialects contain all the families and dialect - * versions that precede the argument dialect. + * versions that precede the argument dialect, including the argument + * dialect. */ @NotNull public static final Set supportedUntil(SQLDialect dialect) { @@ -895,7 +897,8 @@ public enum SQLDialect { * version. *

* The resulting set of dialects contain all the families and dialect - * versions that precede the argument dialect. + * versions that precede the argument dialect, including the argument + * dialects. */ @NotNull public static final Set supportedUntil(SQLDialect... dialects) { @@ -907,7 +910,8 @@ public enum SQLDialect { * version. *

* The resulting set of dialects contain all the families and dialect - * versions that support the argument dialect, i.e. that succeed it. + * versions that support the argument dialect, i.e. that succeed it, + * including the argument dialect. */ @NotNull public static final Set supportedBy(SQLDialect dialect) { @@ -921,7 +925,8 @@ public enum SQLDialect { * dialect versions. *

* The resulting set of dialects contain all the families and dialect - * versions that support the argument dialects, i.e. that succeed them. + * versions that support the argument dialects, i.e. that succeed them, + * including the argument dialects. */ @NotNull public static final Set supportedBy(SQLDialect... dialects) { diff --git a/jOOQ/src/main/java/org/jooq/impl/Pivot.java b/jOOQ/src/main/java/org/jooq/impl/Pivot.java index c39ff30984..f02b45c7dd 100644 --- a/jOOQ/src/main/java/org/jooq/impl/Pivot.java +++ b/jOOQ/src/main/java/org/jooq/impl/Pivot.java @@ -37,9 +37,35 @@ */ package org.jooq.impl; -// ... -// ... -// ... + + + + + + + + + + + + + + + + + + + + + + + + + + + + +