From f753ccd850738255b2cfe7719d089e1623d24ecb Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Tue, 24 Sep 2013 11:44:45 +0200 Subject: [PATCH] [#2597] f1.concat(f2).toString() seems to render unnecessary cast expression --- jOOQ/src/main/java/org/jooq/impl/AbstractField.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/AbstractField.java b/jOOQ/src/main/java/org/jooq/impl/AbstractField.java index a620d542d7..06315deacc 100644 --- a/jOOQ/src/main/java/org/jooq/impl/AbstractField.java +++ b/jOOQ/src/main/java/org/jooq/impl/AbstractField.java @@ -184,9 +184,17 @@ abstract class AbstractField extends AbstractQueryPart implements Field { } } + @SuppressWarnings("unchecked") @Override public final Field cast(Class type) { - return cast(DefaultDataType.getDataType(null, type)); + + // [#2597] Prevent unnecessary casts + if (getType() == type) { + return (Field) this; + } + else { + return cast(DefaultDataType.getDataType(null, type)); + } } // ------------------------------------------------------------------------