From f195735676965cc4e913fd638584a03909efadf4 Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Thu, 16 Dec 2021 10:01:07 +0100 Subject: [PATCH] [jOOQ/jOOQ#12741] Loader.onDuplicateKeyIgnore doesn't work on tables that don't have a PRIMARY KEY --- jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java b/jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java index e947c0fd27..497ffccee2 100644 --- a/jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java @@ -847,11 +847,8 @@ final class LoaderImpl implements addValueForUpdate0(insert, fields[i], row[i]); } - // [#5200] When the primary key is not supplied in the data, - // we'll assume it uses an identity, and there will never be duplicates - // [#10358] TODO: The above should be moved inside InsertQueryImpl // [#7253] Use native onDuplicateKeyIgnore() support - else if (onDuplicate == ON_DUPLICATE_KEY_IGNORE && primaryKey.cardinality() > 0) { + else if (onDuplicate == ON_DUPLICATE_KEY_IGNORE) { insert.onDuplicateKeyIgnore(true); }