From ec0608399e09e42b73807cda2a319490f57aa98b Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Wed, 21 Sep 2022 16:40:40 +0200 Subject: [PATCH] [jOOQ/jOOQ#13182] Improve formatting XMLATTRIBUTES --- jOOQ/src/main/java/org/jooq/impl/XMLAttributesImpl.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/XMLAttributesImpl.java b/jOOQ/src/main/java/org/jooq/impl/XMLAttributesImpl.java index 064a0c00f7..44a38675f9 100644 --- a/jOOQ/src/main/java/org/jooq/impl/XMLAttributesImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/XMLAttributesImpl.java @@ -39,6 +39,8 @@ package org.jooq.impl; // ... import static org.jooq.impl.Names.N_XMLATTRIBUTES; +import static org.jooq.impl.Tools.isSimple; +import static org.jooq.impl.Tools.unalias; import static org.jooq.impl.Tools.BooleanDataKey.DATA_AS_REQUIRED; import static org.jooq.impl.XMLElement.xmlCastMapper; @@ -77,7 +79,10 @@ final class XMLAttributesImpl extends AbstractQueryPart implements XMLAttributes - boolean format = attributes.size() > 1; + boolean format = ctx.format() && ( + attributes.size() > 1 + || attributes.size() == 1 && !isSimple(ctx, unalias(attributes.get(0))) + ); ctx.data(DATA_AS_REQUIRED, true, c -> { c.visit(N_XMLATTRIBUTES).sql('(');