From ead4acf617e482e629886f1e85082c8a1cbe88cf Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Fri, 3 Jul 2020 17:34:45 +0200 Subject: [PATCH] [jOOQ/jOOQ#10358] Added TODO --- jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java b/jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java index 2fe56f6e01..76c58e2df0 100644 --- a/jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/LoaderImpl.java @@ -791,9 +791,10 @@ final class LoaderImpl implements addValueForUpdate0(insert, fields[i], row[i]); } - // [#5200] When the primary key is not supplied in the data, - // we'll assume it uses an identity, and there will never be duplicates - // [#7253] Use native onDuplicateKeyIgnore() support + // [#5200] When the primary key is not supplied in the data, + // we'll assume it uses an identity, and there will never be duplicates + // [#10358] The above should be moved inside InsertQueryImpl + // [#7253] Use native onDuplicateKeyIgnore() support else if (onDuplicate == ON_DUPLICATE_KEY_IGNORE && primaryKey.cardinality() > 0) { insert.onDuplicateKeyIgnore(true); }