From e97216bb100835ddba4c4891f4e7208e5f0021d3 Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Thu, 17 Oct 2024 11:07:27 +0200 Subject: [PATCH] [jOOQ/jOOQ#9085] Inverse defaults for COMMENT ON VIEW --- jOOQ/src/main/java/org/jooq/impl/CommentOnImpl.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/CommentOnImpl.java b/jOOQ/src/main/java/org/jooq/impl/CommentOnImpl.java index 90c6c224ba..ce2097c056 100644 --- a/jOOQ/src/main/java/org/jooq/impl/CommentOnImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/CommentOnImpl.java @@ -153,8 +153,8 @@ implements - private static final Set SUPPORTS_COMMENT_ON_VIEW = SQLDialect.supportedBy(FIREBIRD, POSTGRES, TRINO, YUGABYTEDB); - private static final Set SUPPORTS_COMMENT_ON_MATERIALIZED_VIEW = SQLDialect.supportedBy(POSTGRES, YUGABYTEDB); + private static final Set NO_SUPPORT_COMMENT_ON_VIEW = SQLDialect.supportedBy(CLICKHOUSE, CUBRID, DERBY, DUCKDB, H2, HSQLDB, IGNITE, MARIADB, MYSQL, SQLITE); + private static final Set NO_SUPPORT_COMMENT_ON_MATERIALIZED_VIEW = SQLDialect.supportedBy(CLICKHOUSE, CUBRID, DERBY, DUCKDB, FIREBIRD, H2, HSQLDB, IGNITE, MARIADB, MYSQL, SQLITE, TRINO); @Override public final void accept(Context ctx) { @@ -284,9 +284,9 @@ implements ctx.visit(K_COMMENT).sql(' ').visit(K_ON).sql(' '); if (table != null) { - if (isView && SUPPORTS_COMMENT_ON_VIEW.contains(ctx.dialect())) + if (isView && !NO_SUPPORT_COMMENT_ON_VIEW.contains(ctx.dialect())) ctx.visit(K_VIEW).sql(' '); - else if (isMaterializedView && SUPPORTS_COMMENT_ON_MATERIALIZED_VIEW.contains(ctx.dialect())) + else if (isMaterializedView && !NO_SUPPORT_COMMENT_ON_MATERIALIZED_VIEW.contains(ctx.dialect())) ctx.visit(K_MATERIALIZED).sql(' ').visit(K_VIEW).sql(' '); else ctx.visit(K_TABLE).sql(' ');