From ded3fa5a61e6d7eba65f70eb92d73f1e328dd279 Mon Sep 17 00:00:00 2001
From: Lukas Eder <lukas.eder@gmail.com>
Date: Wed, 3 May 2023 15:04:35 +0200
Subject: [PATCH] [jOOQ/jOOQ#14985] Explicit path joins must have explicit ON
 calls

In SelectImpl, we can't leave the object in some limbo state where the last JOIN isn't added to the tree because of a lacking ON call.
---
 jOOQ/src/main/java/org/jooq/impl/SelectImpl.java | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/jOOQ/src/main/java/org/jooq/impl/SelectImpl.java b/jOOQ/src/main/java/org/jooq/impl/SelectImpl.java
index 6a21c2c01c..a1f1e9a469 100644
--- a/jOOQ/src/main/java/org/jooq/impl/SelectImpl.java
+++ b/jOOQ/src/main/java/org/jooq/impl/SelectImpl.java
@@ -39,6 +39,7 @@ package org.jooq.impl;
 
 import static org.jooq.impl.DSL.condition;
 import static org.jooq.impl.DSL.exists;
+import static org.jooq.impl.DSL.noCondition;
 import static org.jooq.impl.DSL.notExists;
 import static org.jooq.impl.DSL.table;
 import static org.jooq.impl.Tools.EMPTY_FIELD;
@@ -2254,7 +2255,7 @@ implements
 
     @Override
     public final SelectImpl innerJoin(Path<?> path) {
-        return join(path, JoinType.JOIN);
+        return join(path, JoinType.JOIN).on(noCondition());
     }
 
     @Override
@@ -2274,7 +2275,7 @@ implements
 
     @Override
     public final SelectImpl leftOuterJoin(Path<?> path) {
-        return join(path, JoinType.LEFT_OUTER_JOIN);
+        return join(path, JoinType.LEFT_OUTER_JOIN).on(noCondition());
     }
 
     @Override
@@ -2294,7 +2295,7 @@ implements
 
     @Override
     public final SelectImpl rightOuterJoin(Path<?> path) {
-        return join(path, JoinType.RIGHT_OUTER_JOIN);
+        return join(path, JoinType.RIGHT_OUTER_JOIN).on(noCondition());
     }
 
     @Override
@@ -2314,7 +2315,7 @@ implements
 
     @Override
     public final SelectImpl fullOuterJoin(Path<?> path) {
-        return join(path, JoinType.FULL_OUTER_JOIN);
+        return join(path, JoinType.FULL_OUTER_JOIN).on(noCondition());
     }
 
     @Override
@@ -2379,7 +2380,7 @@ implements
 
     @Override
     public final SelectImpl leftSemiJoin(Path<?> path) {
-        return join(path, JoinType.LEFT_SEMI_JOIN);
+        return join(path, JoinType.LEFT_SEMI_JOIN).on(noCondition());
     }
 
     @Override
@@ -2389,7 +2390,7 @@ implements
 
     @Override
     public final SelectImpl leftAntiJoin(Path<?> path) {
-        return join(path, JoinType.LEFT_ANTI_JOIN);
+        return join(path, JoinType.LEFT_ANTI_JOIN).on(noCondition());
     }
 
     @Override
@@ -2409,7 +2410,7 @@ implements
 
     @Override
     public final SelectImpl straightJoin(Path<?> path) {
-        return join(path, JoinType.STRAIGHT_JOIN);
+        return join(path, JoinType.STRAIGHT_JOIN).on(noCondition());
     }
 
     @Override