From ddd49bfbf28a597e0dfbb5547566a1f6ef908287 Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Thu, 24 Sep 2020 12:23:35 +0200 Subject: [PATCH] [jOOQ/jOOQ#7312] Don't mutate input expression tree in transformation! --- jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java | 2 ++ jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java | 9 ++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java b/jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java index 1c0b15258b..d4e4fb1747 100644 --- a/jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java +++ b/jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java @@ -143,6 +143,8 @@ final class CombinedCondition extends AbstractCondition { if (newList == null) return this; + else if (newList.isEmpty()) + return noCondition(); else return of(operator, newList); } diff --git a/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java b/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java index 77eac3d8ab..43e52692f6 100644 --- a/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java @@ -180,7 +180,6 @@ import java.util.Arrays; import java.util.Collection; import java.util.Deque; import java.util.EnumSet; -import java.util.Iterator; import java.util.LinkedHashMap; import java.util.List; import java.util.Map; @@ -2504,6 +2503,14 @@ final class SelectQueryImpl extends AbstractResultQuery imp + + + + + + + +