From db6cfd14959efb25a092b1f6454f5f58e0e1440e Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Wed, 19 Jan 2022 11:51:42 +0100 Subject: [PATCH] [jOOQ/jOOQ#12896] Wrong ON/OFF semantics --- jOOQ/src/main/java/org/jooq/impl/Expression.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/Expression.java b/jOOQ/src/main/java/org/jooq/impl/Expression.java index 4f8df8522c..f2e0d6dd05 100644 --- a/jOOQ/src/main/java/org/jooq/impl/Expression.java +++ b/jOOQ/src/main/java/org/jooq/impl/Expression.java @@ -50,7 +50,7 @@ import static org.jooq.SQLDialect.POSTGRES; // ... // ... import static org.jooq.SQLDialect.YUGABYTEDB; -import static org.jooq.conf.RenderOptionalKeyword.OFF; +import static org.jooq.conf.RenderOptionalKeyword.ON; import static org.jooq.impl.DSL.inline; import static org.jooq.impl.DSL.inlined; import static org.jooq.impl.DSL.keyword; @@ -104,7 +104,6 @@ import org.jooq.Param; import org.jooq.QueryPart; import org.jooq.SQLDialect; import org.jooq.Typed; -import org.jooq.conf.RenderOptionalKeyword; import org.jooq.conf.TransformUnneededArithmeticExpressions; import org.jooq.exception.DataTypeException; import org.jooq.impl.QOM.UOperator2; @@ -880,7 +879,7 @@ final class Expression extends AbstractTransformable implements UOperator2 e.lhs instanceof Typed && e.rhs instanceof Typed ? ((Typed) e.lhs).getDataType().equals(((Typed) e.rhs).getDataType()) : true - ) && !OFF.equals(ctx.settings().getRenderOptionalAssociativityParentheses()); + ) && !ON.equals(ctx.settings().getRenderOptionalAssociativityParentheses()); acceptAssociative(ctx, associativity, e.lhs, e.op, expType, expProvider, formatSeparator); formatSeparator.accept(ctx);