github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#13593] Implement transformPatternsCountConstant

Browse Source
This commit is contained in:
Lukas Eder 2022-10-27 10:54:06 +02:00
parent 157f822e7b
commit da8a79452f
3 changed files with 71 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
jOOQ/src/main/java/org/jooq/conf/Settings.java
View File

@ -141,6 +141,8 @@ public class Settings
@XmlElement(defaultValue = "true")
protected Boolean transformPatternsLogging = true;
@XmlElement(defaultValue = "true")
protected Boolean transformPatternsCountConstant = true;
@XmlElement(defaultValue = "true")
protected Boolean transformPatternsTrim = true;
@XmlElement(defaultValue = "true")
protected Boolean transformPatternsNotNot = true;
@ -1587,6 +1589,37 @@ public class Settings
this.transformPatternsLogging = value;
}
/**
* Transform <code>COUNT(1)</code> or any other <code>COUNT(const)</code> to <code>COUNT(*)</code>.
* <p>
* There is no benefit to counting a constant expression. In fact, in some RDBMS, it might even be slightly
* slower, at least in benchmarks.
* <p>
* To enable this feature, {@link #transformPatterns} must be enabled as well.
* <p>
* This feature is available in the commercial distribution only.
*
* @return
* possible object is
* {@link Boolean }
*
*/
public Boolean isTransformPatternsCountConstant() {
return transformPatternsCountConstant;
}
/**
* Sets the value of the transformPatternsCountConstant property.
*
* @param value
* allowed object is
* {@link Boolean }
*
*/
public void setTransformPatternsCountConstant(Boolean value) {
this.transformPatternsCountConstant = value;
}
/**
* Transform <code>LTRIM(RTRIM(x))</code> or <code>RTRIM(LTRIM(x))</code> to <code>TRIM(x)</code>.
* <p>
@ -4940,6 +4973,11 @@ public class Settings
return this;
}
public Settings withTransformPatternsCountConstant(Boolean value) {
setTransformPatternsCountConstant(value);
return this;
}
public Settings withTransformPatternsTrim(Boolean value) {
setTransformPatternsTrim(value);
return this;
@ -5971,6 +6009,7 @@ public class Settings
builder.append("diagnosticsNullCondition", diagnosticsNullCondition);
builder.append("transformPatterns", transformPatterns);
builder.append("transformPatternsLogging", transformPatternsLogging);
builder.append("transformPatternsCountConstant", transformPatternsCountConstant);
builder.append("transformPatternsTrim", transformPatternsTrim);
builder.append("transformPatternsNotNot", transformPatternsNotNot);
builder.append("transformPatternsNotComparison", transformPatternsNotComparison);
@ -6527,6 +6566,15 @@ public class Settings
return false;
}
}
if (transformPatternsCountConstant == null) {
if (other.transformPatternsCountConstant!= null) {
return false;
}
} else {
if (!transformPatternsCountConstant.equals(other.transformPatternsCountConstant)) {
return false;
}
}
if (transformPatternsTrim == null) {
if (other.transformPatternsTrim!= null) {
return false;
@ -7749,6 +7797,7 @@ public class Settings
result = ((prime*result)+((diagnosticsNullCondition == null)? 0 :diagnosticsNullCondition.hashCode()));
result = ((prime*result)+((transformPatterns == null)? 0 :transformPatterns.hashCode()));
result = ((prime*result)+((transformPatternsLogging == null)? 0 :transformPatternsLogging.hashCode()));
result = ((prime*result)+((transformPatternsCountConstant == null)? 0 :transformPatternsCountConstant.hashCode()));
result = ((prime*result)+((transformPatternsTrim == null)? 0 :transformPatternsTrim.hashCode()));
result = ((prime*result)+((transformPatternsNotNot == null)? 0 :transformPatternsNotNot.hashCode()));
result = ((prime*result)+((transformPatternsNotComparison == null)? 0 :transformPatternsNotComparison.hashCode()));

11
jOOQ/src/main/java/org/jooq/impl/Patterns.java
View File

@ -1678,6 +1678,17 @@ package org.jooq.impl;

11
jOOQ/src/main/resources/org/jooq/xsd/jooq-runtime-3.18.0.xsd
View File

@ -376,6 +376,17 @@ This feature is available in the commercial distribution only.]]></jxb:javadoc><
<annotation><appinfo><jxb:property><jxb:javadoc><![CDATA[Activate debug logging of the {@link #transformPatterns} feature.]]></jxb:javadoc></jxb:property></appinfo></annotation>
</element>
<element name="transformPatternsCountConstant" type="boolean" minOccurs="0" maxOccurs="1" default="true">
<annotation><appinfo><jxb:property><jxb:javadoc><![CDATA[Transform <code>COUNT(1)</code> or any other <code>COUNT(const)</code> to <code>COUNT(*)</code>.
<p>
There is no benefit to counting a constant expression. In fact, in some RDBMS, it might even be slightly
slower, at least in benchmarks.
<p>
To enable this feature, {@link #transformPatterns} must be enabled as well.
<p>
This feature is available in the commercial distribution only.]]></jxb:javadoc></jxb:property></appinfo></annotation>
</element>
<element name="transformPatternsTrim" type="boolean" minOccurs="0" maxOccurs="1" default="true">
<annotation><appinfo><jxb:property><jxb:javadoc><![CDATA[Transform <code>LTRIM(RTRIM(x))</code> or <code>RTRIM(LTRIM(x))</code> to <code>TRIM(x)</code>.
<p>