github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#228] Fix equals() and hashCode() in the UDTPath hierarchy

Browse Source 
A UDTPath can have a Table qualifier, in case of which we mustn't use
the UDT for equals() and hashCode() implementations, but make sure the
behaviour is the same as that of a TableField
This commit is contained in:
Lukas Eder 2023-11-13 14:32:39 +01:00
parent 98e739494b
commit d9a2f7b678
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
jOOQ/src/main/java/org/jooq/impl/UDTPathFieldImpl.java
View File

@ -61,6 +61,7 @@ import org.jooq.RecordQualifier;
import org.jooq.Row;
import org.jooq.Schema;
import org.jooq.Table;
import org.jooq.TableField;
// ...
import org.jooq.UDT;
import org.jooq.UDTPathField;
@ -223,10 +224,15 @@ implements
@Override
public int hashCode() {
return defaultIfNull(getQualifier().getSchema(), DEFAULT_SCHEMA.get()).getQualifiedName()
.append(getQualifier().getUnqualifiedName())
.append(getUDT().getUnqualifiedName())
.append(getUnqualifiedName()).hashCode();
if (getQualifier() instanceof Table)
return defaultIfNull(getQualifier().getSchema(), DEFAULT_SCHEMA.get()).getQualifiedName()
.append(getQualifier().getUnqualifiedName())
.append(getUnqualifiedName()).hashCode();
else
return defaultIfNull(getQualifier().getSchema(), DEFAULT_SCHEMA.get()).getQualifiedName()
.append(getQualifier().getUnqualifiedName())
.append(getUDT().getUnqualifiedName())
.append(getUnqualifiedName()).hashCode();
}
@Override
@ -234,9 +240,15 @@ implements
if (this == that)
return true;
if (getQualifier() instanceof Table && that instanceof TableField<?, ?> other) {
return
StringUtils.equals(getQualifier(), other.getTable()) &&
StringUtils.equals(getName(), other.getName());
}
// [#2144] UDTPathFieldImpl equality can be decided without executing the
// rather expensive implementation of AbstractQueryPart.equals()
if (that instanceof UDTPathField<?, ?, ?> other) {
else if (that instanceof UDTPathField<?, ?, ?> other) {
return
StringUtils.equals(getQualifier(), other.getQualifier()) &&
StringUtils.equals(getUDT(), other.getUDT()) &&