github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#1937] Inefficient implementations of AbstractDataType.equals() and

Browse Source 
hashCode()
This commit is contained in:
Lukas Eder 2012-11-06 23:36:50 +01:00
parent a70ba0f67f
commit d39a5dcb1c
1 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
jOOQ/src/main/java/org/jooq/impl/AbstractDataType.java
View File

@ -526,11 +526,37 @@ public abstract class AbstractDataType<T> implements DataType<T> {
@Override
public int hashCode() {
return toString().hashCode();
final int prime = 31;
int result = 1;
result = prime * result + ((dialect == null) ? 0 : dialect.hashCode());
result = prime * result + ((type == null) ? 0 : type.hashCode());
result = prime * result + ((typeName == null) ? 0 : typeName.hashCode());
return result;
}
@Override
public boolean equals(Object obj) {
return toString().equals("" + obj);
if (this == obj)
return true;
if (obj == null)
return false;
if (getClass() != obj.getClass())
return false;
AbstractDataType<?> other = (AbstractDataType<?>) obj;
if (dialect != other.dialect)
return false;
if (type == null) {
if (other.type != null)
return false;
}
else if (!type.equals(other.type))
return false;
if (typeName == null) {
if (other.typeName != null)
return false;
}
else if (!typeName.equals(other.typeName))
return false;
return true;
}
}