From cf80bc723ce4f8db766d4ddb70ecb87a8808c42d Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Fri, 12 Feb 2021 16:33:06 +0100 Subject: [PATCH] [jOOQ/jOOQ#10572] Wrong DSL::countDistinct method used by parser Parser is parsing countDistinct(Field[]) regardless of the number of argument fields, rather than countDistinct(Field). This may lead to some tests being skipped for dialects that do not support countDistinct(Field[]) --- jOOQ/src/main/java/org/jooq/impl/ParserImpl.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/ParserImpl.java b/jOOQ/src/main/java/org/jooq/impl/ParserImpl.java index c580e28875..465735bf2a 100644 --- a/jOOQ/src/main/java/org/jooq/impl/ParserImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/ParserImpl.java @@ -10886,10 +10886,10 @@ final class ParserContext { if (distinct) if (fields == null) return countDistinct(asterisk); - else if (fields.length > 0) - return countDistinct(fields); - else + else if (fields.length == 1) return countDistinct(fields[0]); + else + return countDistinct(fields); else if (fields == null) return count(asterisk); else