github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#9085] [jOOQ/jOOQ#8640] Change default ON DUPLICATE KEY IGNORE

Browse Source 
The default SQL generated for unattached queries shouldn't throw exceptions, but generate something meaningful instead. This change switches the default emulation of ON DUPLICATE KEY IGNORE from INSERT .. SELECT (which requires constraint meta data) to MySQL's INSERT IGNORE
This commit is contained in:
Lukas Eder 2021-10-15 17:21:16 +02:00
parent a9021b208d
commit ccd55c92f7
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
jOOQ/src/main/java/org/jooq/impl/InsertQueryImpl.java
View File

@ -441,7 +441,7 @@ final class InsertQueryImpl<R extends Record> extends AbstractStoreQuery<R> impl
else if (onDuplicateKeyIgnore) {
switch (ctx.dialect()) {
// MySQL has a nice, native syntax for this
// The default emulation
@ -451,14 +451,18 @@ final class InsertQueryImpl<R extends Record> extends AbstractStoreQuery<R> impl
case FIREBIRD:
case MYSQL:
case MARIADB: {
toSQLInsert(ctx);
ctx.start(INSERT_ON_DUPLICATE_KEY_UPDATE)
.end(INSERT_ON_DUPLICATE_KEY_UPDATE);
case IGNITE:
{
ctx.visit(toInsertSelect(ctx.configuration()));
break;
}
@ -578,8 +582,11 @@ final class InsertQueryImpl<R extends Record> extends AbstractStoreQuery<R> impl
break;
}
// MySQL has a nice, native syntax for this
default: {
ctx.visit(toInsertSelect(ctx.configuration()));
toSQLInsert(ctx);
ctx.start(INSERT_ON_DUPLICATE_KEY_UPDATE)
.end(INSERT_ON_DUPLICATE_KEY_UPDATE);
break;
}
}