From c8e26b04d60f247317a7795abf2dbcbbb3f9dd2e Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Mon, 8 May 2023 09:06:33 +0200 Subject: [PATCH] [jOOQ/jOOQ#15039] The exported DDL of the table for POSTGRES_15 dialect is missing a default value --- jOOQ/src/main/java/org/jooq/impl/Tools.java | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/Tools.java b/jOOQ/src/main/java/org/jooq/impl/Tools.java index 5aa18277a4..f411e37261 100644 --- a/jOOQ/src/main/java/org/jooq/impl/Tools.java +++ b/jOOQ/src/main/java/org/jooq/impl/Tools.java @@ -72,6 +72,7 @@ import static org.jooq.SQLDialect.POSTGRES; // ... // ... // ... +// ... import static org.jooq.SQLDialect.SQLITE; // ... // ... @@ -5659,6 +5660,7 @@ final class Tools { } private static final Set REQUIRE_IDENTITY_AFTER_NULL = SQLDialect.supportedBy(H2, MARIADB, MYSQL); + private static final Set SUPPORT_PG_IDENTITY = SQLDialect.supportedBy(POSTGRES); /** * If a type is an identity type, some dialects require the relevant @@ -5684,15 +5686,9 @@ final class Tools { case HSQLDB: ctx.sql(' ').visit(K_GENERATED).sql(' ').visit(K_BY).sql(' ').visit(K_DEFAULT).sql(' ').visit(K_AS).sql(' ').visit(K_IDENTITY).sql('(').visit(K_START_WITH).sql(" 1)"); break; case SQLITE: ctx.sql(' ').visit(K_PRIMARY_KEY).sql(' ').visit(K_AUTOINCREMENT); break; case POSTGRES: - switch (ctx.dialect()) { + if (SUPPORT_PG_IDENTITY.contains(ctx.dialect())) + ctx.sql(' ').visit(K_GENERATED).sql(' ').visit(K_BY).sql(' ').visit(K_DEFAULT).sql(' ').visit(K_AS).sql(' ').visit(K_IDENTITY); - - - - - case POSTGRES: - ctx.sql(' ').visit(K_GENERATED).sql(' ').visit(K_BY).sql(' ').visit(K_DEFAULT).sql(' ').visit(K_AS).sql(' ').visit(K_IDENTITY); break; - } break;