github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#1727] Cast VARCHAR bind values to their actual string length in

Browse Source 
Firebird
This commit is contained in:
Lukas Eder 2012-08-23 19:27:24 +02:00
parent da54e2db78
commit c8d2b997dc
1 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
jOOQ/src/main/java/org/jooq/impl/Val.java
View File

@ -233,12 +233,10 @@ class Val<T> extends AbstractField<T> implements Param<T> {
toSQL(context, getValue(), getType());
}
// [#1727] VARCHAR types should be cast to their actual lengths
else if (getValue() != null && type == SQLDataType.VARCHAR) {
// Multiply by 4 to be sure that even UTF-32 collations will fit
// But don't use larger numbers than Derby's upper limit 32672
toSQLCast(context, getDataType(context), Math.min(32672, 4 * ((String) getValue()).length()));
// [#1727] VARCHAR types should be cast to their actual lengths in some
// dialects
else if (getValue() != null && type == SQLDataType.VARCHAR && asList(FIREBIRD).contains(context.getDialect())) {
toSQLCast(context, getDataType(context), getValueLength());
}
// In all other cases, the bind variable can be cast normally
@ -247,6 +245,28 @@ class Val<T> extends AbstractField<T> implements Param<T> {
}
}
private int getValueLength() {
String string = (String) getValue();
if (string == null) {
return 1;
}
else {
int length = string.length();
// If non 7-bit ASCII characters are present, multiply the length by
// 4 to be sure that even UTF-32 collations will fit. But don't use
// larger numbers than Derby's upper limit 32672
for (int i = 0; i < length; i++) {
if (string.charAt(i) > 127) {
return Math.min(32672, 4 * length);
}
}
return Math.min(32672, length);
}
}
private void toSQLCast(RenderContext context, DataType<?> type, int length) {
context.keyword("cast(");
toSQL(context, getValue(), getType());