From c3c87ee6c77f7fa12fb8512ecc7b3d1cc2c1f1f5 Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Sun, 28 Apr 2013 16:39:31 +0200 Subject: [PATCH] [#1520] Handle Ingres', SQLite, SQL Server's, Sybase ASE's limitations of 1024, 999, 2100 or 2000 maximum bind values per query --- jOOQ/src/main/java/org/jooq/impl/AbstractRoutine.java | 3 ++- jOOQ/src/main/java/org/jooq/impl/BatchSingle.java | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/AbstractRoutine.java b/jOOQ/src/main/java/org/jooq/impl/AbstractRoutine.java index 4089ed0b8f..66be6e190d 100644 --- a/jOOQ/src/main/java/org/jooq/impl/AbstractRoutine.java +++ b/jOOQ/src/main/java/org/jooq/impl/AbstractRoutine.java @@ -257,6 +257,7 @@ public abstract class AbstractRoutine extends AbstractQueryPart implements Ro Connection connection = ctx.connection(); listener.renderStart(ctx); + // [#1520] TODO: Should the number of bind values be checked, here? ctx.sql(create(configuration).render(this)); listener.renderEnd(ctx); @@ -653,7 +654,7 @@ public abstract class AbstractRoutine extends AbstractQueryPart implements Ro } // [#2393] Fully qualify custom aggregate functions. - // TODO: Merge this code into RoutineField! + // TODO: Merge this code into RoutineField! List names = new ArrayList(); if (schema != null) { names.add(schema.getName()); diff --git a/jOOQ/src/main/java/org/jooq/impl/BatchSingle.java b/jOOQ/src/main/java/org/jooq/impl/BatchSingle.java index d67db54437..ffa2900126 100644 --- a/jOOQ/src/main/java/org/jooq/impl/BatchSingle.java +++ b/jOOQ/src/main/java/org/jooq/impl/BatchSingle.java @@ -120,6 +120,7 @@ class BatchSingle implements BatchBindStep { try { listener.renderStart(ctx); + // [#1520] TODO: Should the number of bind values be checked, here? ctx.sql(create.render(query)); listener.renderEnd(ctx);