From c21eebb065b1512729c6f579ffb821fa699784c7 Mon Sep 17 00:00:00 2001
From: lukaseder <lukas.eder@gmail.com>
Date: Wed, 19 Jul 2017 13:25:07 +0200
Subject: [PATCH] [#6427] Deprecate partitionByOne() API

---
 jOOQ/src/main/java/org/jooq/WindowPartitionByStep.java       | 5 +++++
 .../java/org/jooq/WindowSpecificationPartitionByStep.java    | 5 +++++
 jOOQ/src/main/java/org/jooq/impl/Function.java               | 1 +
 .../src/main/java/org/jooq/impl/WindowSpecificationImpl.java | 1 +
 4 files changed, 12 insertions(+)

diff --git a/jOOQ/src/main/java/org/jooq/WindowPartitionByStep.java b/jOOQ/src/main/java/org/jooq/WindowPartitionByStep.java
index 66a5ecf556..467bb4e283 100644
--- a/jOOQ/src/main/java/org/jooq/WindowPartitionByStep.java
+++ b/jOOQ/src/main/java/org/jooq/WindowPartitionByStep.java
@@ -77,7 +77,12 @@ public interface WindowPartitionByStep<T> extends WindowOrderByStep<T> {
      * <p>
      * This clause is not supported as such in the CUBRID and Sybase dialects.
      * If you use it, jOOQ will simply ignore it.
+     *
+     * @deprecated - 3.10 - [#6427] - This synthetic clause is no longer
+     *             supported, use {@link #partitionBy(Field...)} instead, or
+     *             omit the clause entirely.
      */
+    @Deprecated
     @Support({ CUBRID, FIREBIRD_3_0, MYSQL_8_0, POSTGRES })
     WindowOrderByStep<T> partitionByOne();
 
diff --git a/jOOQ/src/main/java/org/jooq/WindowSpecificationPartitionByStep.java b/jOOQ/src/main/java/org/jooq/WindowSpecificationPartitionByStep.java
index 1aab3b6a8a..741da1b8f8 100644
--- a/jOOQ/src/main/java/org/jooq/WindowSpecificationPartitionByStep.java
+++ b/jOOQ/src/main/java/org/jooq/WindowSpecificationPartitionByStep.java
@@ -82,7 +82,12 @@ public interface WindowSpecificationPartitionByStep extends WindowSpecificationO
      * <p>
      * This clause is not supported as such in the CUBRID and Sybase dialects.
      * If you use it, jOOQ will simply ignore it.
+     *
+     * @deprecated - 3.10 - [#6427] - This synthetic clause is no longer
+     *             supported, use {@link #partitionBy(Field...)} instead, or
+     *             omit the clause entirely.
      */
+    @Deprecated
     @Support({ CUBRID, FIREBIRD_3_0, MYSQL_8_0, POSTGRES })
     WindowSpecificationOrderByStep partitionByOne();
 }
diff --git a/jOOQ/src/main/java/org/jooq/impl/Function.java b/jOOQ/src/main/java/org/jooq/impl/Function.java
index ed35dc4e54..4713b9c116 100644
--- a/jOOQ/src/main/java/org/jooq/impl/Function.java
+++ b/jOOQ/src/main/java/org/jooq/impl/Function.java
@@ -622,6 +622,7 @@ class Function<T> extends AbstractField<T> implements
     }
 
     @Override
+    @Deprecated
     public final WindowOrderByStep<T> partitionByOne() {
         windowSpecification.partitionByOne();
         return this;
diff --git a/jOOQ/src/main/java/org/jooq/impl/WindowSpecificationImpl.java b/jOOQ/src/main/java/org/jooq/impl/WindowSpecificationImpl.java
index 54786086e3..854ba62223 100644
--- a/jOOQ/src/main/java/org/jooq/impl/WindowSpecificationImpl.java
+++ b/jOOQ/src/main/java/org/jooq/impl/WindowSpecificationImpl.java
@@ -169,6 +169,7 @@ final class WindowSpecificationImpl extends AbstractQueryPart implements
     }
 
     @Override
+    @Deprecated
     public final WindowSpecificationOrderByStep partitionByOne() {
         partitionByOne = true;
         partitionBy.add(one());